Re: Code conventions for the build system

2014-01-15 Thread Magnus Ihse Bursie
On 2013-12-18 19:08, Kumar Srinivasan wrote: Hi Magnus, Is this formalized some place ? If not it would be good to get this formalized and posted on a wiki or at http://openjdk.java.net/groups/build/ You are absolutely correct, they should be in a better place. And now they are! (Better la

Re: Code conventions for the build system

2013-12-18 Thread Kumar Srinivasan
Hi Magnus, Is this formalized some place ? If not it would be good to get this formalized and posted on a wiki or at http://openjdk.java.net/groups/build/ Thanks Kumar On 10/8/2013 12:40 AM, Magnus Ihse Bursie wrote: Whitespace and indentation in makefiles is a more problematic area than f

RE: Code conventions for the build system

2013-10-08 Thread Salter, Thomas A
build-dev@openjdk.java.net Subject: Re: Code conventions for the build system On 2013-10-08 14:08, Salter, Thomas A wrote: > Was there any thought given to using this GNU Make feature to get rid of > significant tab characters, or is it not even possible in all the supported > build environ

Re: Code conventions for the build system

2013-10-08 Thread Magnus Ihse Bursie
On 2013-10-08 14:08, Salter, Thomas A wrote: Was there any thought given to using this GNU Make feature to get rid of significant tab characters, or is it not even possible in all the supported build environments? Some of the legacy systems I deal with don't handle tab characters well. From:

Re: Code conventions for the build system

2013-10-08 Thread Salter, Thomas A
rom: Magnus Ihse Bursie Subject: Code conventions for the build system To: build-dev Message-ID: <5253b6ec.9020...@oracle.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Whitespace and indentation in makefiles is a more problematic area than for other languages. Even while

Re: Code conventions for the build system

2013-10-08 Thread Volker Simonis
Hi Magnus, great work! I completely agree with all points and especially like the indentation level of two spaces:) Thanks, Volker On Tue, Oct 8, 2013 at 9:40 AM, Magnus Ihse Bursie wrote: > Whitespace and indentation in makefiles is a more problematic area than for > other languages. Even whi

Code conventions for the build system

2013-10-08 Thread Magnus Ihse Bursie
Whitespace and indentation in makefiles is a more problematic area than for other languages. Even while most of the time whitespace is not significant, sometimes is is. This might be considered a design flaw in make, but that's not something we can do anything about. In particular, initial tabs