Re: Code review for bug fix 8025741

2013-10-02 Thread Tim Bell
Bhavesh: Looks good to me as well. /Tim On 10/ 2/13 01:38 AM, Magnus Ihse Bursie wrote: On 2013-10-02 10:32, Bhavesh Patel wrote: Thanks Magnus. I have made the changes to the common/makefiles/javadoc/Javadoc.gmk file for the new build. I have uploaded the updated webrev at http://cr.open

Re: Code review for bug fix 8025741

2013-10-02 Thread Magnus Ihse Bursie
On 2013-10-02 10:32, Bhavesh Patel wrote: Thanks Magnus. I have made the changes to the common/makefiles/javadoc/Javadoc.gmk file for the new build. I have uploaded the updated webrev at http://cr.openjdk.java.net/~bpatel/8025741/webrev.01/ Looks good to me (but you'll need a formal reviewer

Re: Code review for bug fix 8025741

2013-10-02 Thread Bhavesh Patel
: bhavesh.x.pa...@oracle.com Cc: build-dev@openjdk.java.net Sent: Wednesday, October 2, 2013 12:46:19 AM GMT -08:00 US/Canada Pacific Subject: Re: Code review for bug fix 8025741 On 2013-10-01 23:41, Bhavesh Patel wrote: > Hi, > There is a bug in jdk/make/docs/Makefile for JDK8. The bug is lis

Re: Code review for bug fix 8025741

2013-10-02 Thread Magnus Ihse Bursie
On 2013-10-01 23:41, Bhavesh Patel wrote: Hi, There is a bug in jdk/make/docs/Makefile for JDK8. The bug is listed at https://bugs.openjdk.java.net/browse/JDK-8025741. The Makefile for JDK 8 does not include the DEV_DOCS_URL that should point to the developer documentation URL for JDK 8. T

Code review for bug fix 8025741

2013-10-01 Thread Bhavesh Patel
Hi, There is a bug in jdk/make/docs/Makefile for JDK8. The bug is listed at https://bugs.openjdk.java.net/browse/JDK-8025741. The Makefile for JDK 8 does not include the DEV_DOCS_URL that should point to the developer documentation URL for JDK 8. This creates an empty href in HTML tag result