Re: CompileJavaModule.gmk overrides values from a custom extension gmk

2017-09-06 Thread Magnus Ihse Bursie
and within IBM on: Hursley Park Hursley, SO212JN United Kingdom From: Erik Joelsson To: Jason Yong Cc: build-dev@openjdk.java.net Date: 30/08/2017 14:43 Subject: Re: CompileJavaModule.gmk overrides values from a custom extension gmk Hello, Changing the assignment on

Re: CompileJavaModule.gmk overrides values from a custom extension gmk

2017-08-31 Thread Erik Joelsson
256 E-mail: yon...@uk.ibm.com Find me on: and within IBM on: Hursley Park Hursley, SO212JN United Kingdom From: Erik Joelsson To: Jason Yong Cc: build-dev@openjdk.java.net Date: 30/08/2017 13:47 Subject:Re: CompileJavaModule.gmk overrides values from a custom extension gmk

Re: CompileJavaModule.gmk overrides values from a custom extension gmk

2017-08-31 Thread Erik Joelsson
n To: Jason Yong Cc: build-dev@openjdk.java.net Date: 30/08/2017 14:43 Subject: Re: CompileJavaModule.gmk overrides values from a custom extension gmk Hello, Changing the assignment on COPY, CLEAN and FLAGS variables makes sense, but please revert the SETUP variables as those ar

Re: CompileJavaModule.gmk overrides values from a custom extension gmk

2017-08-30 Thread David Holmes
256 E-mail: yon...@uk.ibm.com Find me on:  and within IBM on: Hursley Park Hursley, SO212JN United Kingdom From:   Erik Joelsson To: Jason Yong Cc: build-dev@openjdk.java.net Date:   30/08/2017 13:47 Subject:    Re: CompileJavaModule.gmk overrides values from a custom extension

Re: CompileJavaModule.gmk overrides values from a custom extension gmk

2017-08-30 Thread Erik Joelsson
-mail: yon...@uk.ibm.com Find me on: and within IBM on: Hursley Park Hursley, SO212JN United Kingdom From: Erik Joelsson To: Jason Yong Cc: build-dev@openjdk.java.net Date: 30/08/2017 13:47 Subject: Re: CompileJavaModule.gmk overrides values from a custom extension gmk

Re: CompileJavaModule.gmk overrides values from a custom extension gmk

2017-08-30 Thread Gary Adams
Yong Cc: build-dev@openjdk.java.net Date: 30/08/2017 14:43 Subject: Re: CompileJavaModule.gmk overrides values from a custom extension gmk Hello, Changing the assignment on COPY, CLEAN and FLAGS variables makes sense, but please revert the SETUP variables as those are not list

Re: CompileJavaModule.gmk overrides values from a custom extension gmk

2017-08-30 Thread Erik Joelsson
Erik Joelsson To: Jason Yong Cc: build-dev@openjdk.java.net Date: 30/08/2017 14:43 Subject: Re: CompileJavaModule.gmk overrides values from a custom extension gmk Hello, Changing the assignment on COPY, CLEAN and FLAGS variables makes sense, but please revert the SETUP variabl

Re: CompileJavaModule.gmk overrides values from a custom extension gmk

2017-08-30 Thread Jason Yong
build-dev@openjdk.java.net Date: 30/08/2017 14:43 Subject: Re: CompileJavaModule.gmk overrides values from a custom extension gmk Hello, Changing the assignment on COPY, CLEAN and FLAGS variables makes sense, but please revert the SETUP variables as those are not lists but single value

Re: CompileJavaModule.gmk overrides values from a custom extension gmk

2017-08-30 Thread Erik Joelsson
: yon...@uk.ibm.com Find me on: and within IBM on: Hursley Park Hursley, SO212JN United Kingdom From: Erik Joelsson To: Jason Yong Cc: build-dev@openjdk.java.net Date: 30/08/2017 13:47 Subject: Re: CompileJavaModule.gmk overrides values from a custom extension gmk If you have s

Re: CompileJavaModule.gmk overrides values from a custom extension gmk

2017-08-30 Thread Jason Yong
Erik Joelsson To:Jason Yong , build-dev@openjdk.java.net Date:29/08/2017 12:55 Subject: Re: CompileJavaModule.gmk overrides values from a custom extension gmk Hello Jason, Your suggestion makes sense. The only reason these variables have := today is that we (at Oracle) ha

Re: CompileJavaModule.gmk overrides values from a custom extension gmk

2017-08-30 Thread Erik Joelsson
do?key=acdaa606-99cf-4e69-bdd5-2ea7f0396035> IBM Hursley Park Hursley, SO212JN United Kingdom From: Erik Joelsson To: Jason Yong , build-dev@openjdk.java.net Date: 29/08/2017 12:55 Subject: Re: CompileJavaModule.gmk overrides values from a cus

Re: CompileJavaModule.gmk overrides values from a custom extension gmk

2017-08-29 Thread Erik Joelsson
Hello Jason, Your suggestion makes sense. The only reason these variables have := today is that we (at Oracle) haven't had a need for appending to those particular variables (yet). /Erik On 2017-08-29 11:31, Jason Yong wrote: Hello, I've had an issue where I've had a custom extension to

CompileJavaModule.gmk overrides values from a custom extension gmk

2017-08-29 Thread Jason Yong
Hello, I've had an issue where I've had a custom extension to CompileJavaModules.gmk with the variable java.base_COPY set to files that I wanted to be copied across but its value was overwritten by CompileJavaModules.gmk. I would like to propose changes that would allow a custom extensions to