Re: cross compiling with different toolchain type

2019-11-14 Thread Erik Joelsson
g compiler. Looking into toolchain.m4, this sounds fair to me, as the BuildC compiler (line 916 and below) is also tested with TOOLCHAIN_EXTRACT_COMPILER_VERSION(BUILD_CC, [BuildC]) which unconditionally checks for the $TOOLCHAIN_TYPE. Hence, it seems cross-compiling using a clang compiler, while using

cross compiling with different toolchain type

2019-11-14 Thread Johan Vos
ested with TOOLCHAIN_EXTRACT_COMPILER_VERSION(BUILD_CC, [BuildC]) which unconditionally checks for the $TOOLCHAIN_TYPE. Hence, it seems cross-compiling using a clang compiler, while using gcc as the build compiler is not possible. That's by no means a showstopper to me, I just want to double che

Re: RFR: JDK-8217739: Cannot reuse java.base UnixConstants.java from target in BuildJDK when cross compiling

2019-06-06 Thread Ao Qi
> @@ -71,7 +78,7 @@ > >>>>>>define generate-preproc-src > >>>>>> $(call MakeDir, $(@D)) > >>>>>> ( $(NAWK) '/@@END_COPYRIGHT@@/{exit}1' $< && \ > >>>>>> - $(CPP) $(CP

Re: RFR: JDK-8217739: Cannot reuse java.base UnixConstants.java from target in BuildJDK when cross compiling

2019-06-06 Thread Erik Joelsson
y changed in buildjdk-spec.gmk.in: http://cr.openjdk.java.net/~erikj/8217739/webrev.02/ /Erik On 2019-06-04 07:53, Tim Bell wrote: Erik: Looks good. Tim This is a fix for a problem brought up on this list [1]. The main issue is that when cross compiling, and creating a buildjdk during th

Re: RFR: JDK-8217739: Cannot reuse java.base UnixConstants.java from target in BuildJDK when cross compiling

2019-06-05 Thread Ao Qi
($(GREP) -v '^$(&2) \ > > >>> | $(NAWK) '/@@START_HERE@@/,0' \ > > >>> | $(SED) -e 's/@@START_HERE@@/\/\/ AUTOMATICALLY GENERATED > > >>> FILE - DO NOT EDIT/' \ > > >>> > > >>> >

Re: RFR: JDK-8217739: Cannot reuse java.base UnixConstants.java from target in BuildJDK when cross compiling

2019-06-05 Thread Ao Qi
t; >>> | $(SED) -e 's/@@START_HERE@@/\/\/ AUTOMATICALLY GENERATED > >>> FILE - DO NOT EDIT/' \ > >>> > >>> > >>> Cheers, > >>> Ao Qi > >>> > >>> On Wed, Jun 5, 2019 at 12:00 AM Erik Joelsson &

Re: RFR: JDK-8217739: Cannot reuse java.base UnixConstants.java from target in BuildJDK when cross compiling

2019-06-05 Thread Erik Joelsson
ildjdk-spec.gmk.in: http://cr.openjdk.java.net/~erikj/8217739/webrev.02/ /Erik On 2019-06-04 07:53, Tim Bell wrote: Erik: Looks good. Tim This is a fix for a problem brought up on this list [1]. The main issue is that when cross compiling, and creating a buildjdk during the build, the Uni

Re: RFR: JDK-8217739: Cannot reuse java.base UnixConstants.java from target in BuildJDK when cross compiling

2019-06-05 Thread Erik Joelsson
d. This variable also needs to be rewritten in buildjdk-spec.gmk.in. New webrev, only changed in buildjdk-spec.gmk.in: http://cr.openjdk.java.net/~erikj/8217739/webrev.02/ /Erik On 2019-06-04 07:53, Tim Bell wrote: Erik: Looks good. Tim This is a fix for a problem brought up on this list [1

Re: RFR: JDK-8217739: Cannot reuse java.base UnixConstants.java from target in BuildJDK when cross compiling

2019-06-05 Thread Erik Joelsson
17739/webrev.02/ /Erik On 2019-06-04 07:53, Tim Bell wrote: Erik: Looks good. Tim This is a fix for a problem brought up on this list [1]. The main issue is that when cross compiling, and creating a buildjdk during the build, the UnixConstants.java cannot necessarily be reused between the t

Re: RFR: JDK-8217739: Cannot reuse java.base UnixConstants.java from target in BuildJDK when cross compiling

2019-06-04 Thread Ao Qi
ik: > > > > Looks good. > > > > Tim > > > >> This is a fix for a problem brought up on this list [1]. The main issue > >> is that when cross compiling, and creating a buildjdk during the build, > >> the UnixConstants.java cannot necessarily be r

Re: RFR: JDK-8217739: Cannot reuse java.base UnixConstants.java from target in BuildJDK when cross compiling

2019-06-04 Thread Tim Bell
buildjdk-spec.gmk.in. New webrev, only changed in buildjdk-spec.gmk.in: http://cr.openjdk.java.net/~erikj/8217739/webrev.02/ /Erik On 2019-06-04 07:53, Tim Bell wrote: Erik: Looks good. Tim This is a fix for a problem brought up on this list [1]. The main issue is that when cross compiling, and

Re: RFR: JDK-8217739: Cannot reuse java.base UnixConstants.java from target in BuildJDK when cross compiling

2019-06-04 Thread Erik Joelsson
changed in buildjdk-spec.gmk.in: http://cr.openjdk.java.net/~erikj/8217739/webrev.02/ /Erik On 2019-06-04 07:53, Tim Bell wrote: Erik: Looks good. Tim This is a fix for a problem brought up on this list [1]. The main issue is that when cross compiling, and creating a buildjdk during the build

Re: RFR: JDK-8217739: Cannot reuse java.base UnixConstants.java from target in BuildJDK when cross compiling

2019-06-04 Thread Tim Bell
Erik: Looks good. Tim This is a fix for a problem brought up on this list [1]. The main issue is that when cross compiling, and creating a buildjdk during the build, the UnixConstants.java cannot necessarily be reused between the target JDK and the buildjdk. While investigating this, I came

RFR: JDK-8217739: Cannot reuse java.base UnixConstants.java from target in BuildJDK when cross compiling

2019-06-03 Thread Erik Joelsson
This is a fix for a problem brought up on this list [1]. The main issue is that when cross compiling, and creating a buildjdk during the build, the UnixConstants.java cannot necessarily be reused between the target JDK and the buildjdk. While investigating this, I came to the conclusion that

Re: Fail to cross compiling jdk12 for mips64el-linux-gnu target

2019-01-28 Thread Ao Qi
/Main.gmk:441: recipe for target 'generate-link-opt-data' failed > > make[2]: *** [generate-link-opt-data] Error 2 > > This should have worked, but sounds like something that can typically > fail when cross-compiling. As a workaround, disable class list > generation: &q

Re: Fail to cross compiling jdk12 for mips64el-linux-gnu target

2019-01-25 Thread Ao Qi
Hi John, On Fri, Jan 25, 2019 at 11:10 PM Ao Qi wrote: > > On Fri, Jan 25, 2019 at 10:51 PM John Paul Adrian Glaubitz > wrote: > > > > On 1/25/19 3:44 PM, Ao Qi wrote:> FYI, if one wants to debug this issue, > > below is some sctripts I used > > > to cross compile a mips zero jdk, which can tri

Re: Fail to cross compiling jdk12 for mips64el-linux-gnu target

2019-01-25 Thread Ao Qi
On Fri, Jan 25, 2019 at 10:51 PM John Paul Adrian Glaubitz wrote: > > On 1/25/19 3:44 PM, Ao Qi wrote:> FYI, if one wants to debug this issue, > below is some sctripts I used > > to cross compile a mips zero jdk, which can trigger the bug. > > Native builds on Debian unstable on mips* work? > Wo

Re: Fail to cross compiling jdk12 for mips64el-linux-gnu target

2019-01-25 Thread Ao Qi
Hi, On Fri, Jan 25, 2019 at 10:31 PM John Paul Adrian Glaubitz wrote: > > Hi! > > On 1/24/19 3:28 AM, Leslie Zhai wrote: > > Please give me some advice about how to fix the root cause, thanks a lot! > > Just as a heads-up: In Debian we have two patches required for OpenJDK on the > mips > target

Re: Fail to cross compiling jdk12 for mips64el-linux-gnu target

2019-01-25 Thread John Paul Adrian Glaubitz
On 1/25/19 3:44 PM, Ao Qi wrote:> FYI, if one wants to debug this issue, below is some sctripts I used > to cross compile a mips zero jdk, which can trigger the bug. Native builds on Debian unstable on mips* work? > do one patch [1] then make images What about the alignment patch? Is that still

Re: Fail to cross compiling jdk12 for mips64el-linux-gnu target

2019-01-25 Thread Ao Qi
, > >>>>>> > >>>>>> I'm not Erik :) however > >>>>>> > >>>>>> On 24/01/2019 12:28 pm, Leslie Zhai wrote: > >>>>>>> Hi Erik, > >>>>>>> > >

Re: Fail to cross compiling jdk12 for mips64el-linux-gnu target

2019-01-25 Thread John Paul Adrian Glaubitz
Hi! On 1/24/19 3:28 AM, Leslie Zhai wrote: > Please give me some advice about how to fix the root cause, thanks a lot! Just as a heads-up: In Debian we have two patches required for OpenJDK on the mips targets: > https://git.launchpad.net/~openjdk/ubuntu/+source/openjdk/+git/openjdk/tree/debian

Re: Fail to cross compiling jdk12 for mips64el-linux-gnu target

2019-01-25 Thread Magnus Ihse Bursie
ux-mips64el-normal-server-fastdebug/support/link_opt/classlist' make/Main.gmk:441: recipe for target 'generate-link-opt-data' failed make[2]: *** [generate-link-opt-data] Error 2 This should have worked, but sounds like something that can typically fail when cross-compiling. As a work

Re: Fail to cross compiling jdk12 for mips64el-linux-gnu target

2019-01-24 Thread Leslie Zhai
, Because the flags' macro of MIPS is different from other targets[1], it will effect the `UnixConstants` of src/java.base/unix/classes/sun/nio/fs/UnixConstants.java.template, for example, PREFIX_O_APPEND, so the `Flags` in `FileChannel` is different from other targets.  Then failed[2] to

Re: Fail to cross compiling jdk12 for mips64el-linux-gnu target

2019-01-24 Thread Leslie Zhai
avid Holmes wrote: Hi Leslie, I'm not Erik :) however On 24/01/2019 12:28 pm, Leslie Zhai wrote: Hi Erik, Because the flags' macro of MIPS is different from other targets[1], it will effect the `UnixConstants` of src/java.base/unix/classes/sun/nio/fs/UnixConstants.java

Re: Fail to cross compiling jdk12 for mips64el-linux-gnu target

2019-01-24 Thread Erik Joelsson
: Hi Erik, Because the flags' macro of MIPS is different from other targets[1], it will effect the `UnixConstants` of src/java.base/unix/classes/sun/nio/fs/UnixConstants.java.template, for example, PREFIX_O_APPEND, so the `Flags` in `FileChannel` is different from other targets.  Then fai

Re: Fail to cross compiling jdk12 for mips64el-linux-gnu target

2019-01-24 Thread Magnus Ihse Bursie
the `Flags` in `FileChannel` is different from other targets.  Then failed[2] to cross compiling jdk12 for mips64el-linux-gnu target by following the document[3]. It's been quite a while since we built for a platform where the flags had different values, but it is supposed to work. I suspec

Re: Fail to cross compiling jdk12 for mips64el-linux-gnu target

2019-01-24 Thread Leslie Zhai
from other targets.  Then failed[2] to cross compiling jdk12 for mips64el-linux-gnu target by following the document[3]. It's been quite a while since we built for a platform where the flags had different values, but it is supposed to work. I suspect that the way we build now with the mo

Re: Fail to cross compiling jdk12 for mips64el-linux-gnu target

2019-01-24 Thread Magnus Ihse Bursie
erent from other targets[1], it will effect the `UnixConstants` of src/java.base/unix/classes/sun/nio/fs/UnixConstants.java.template, for example, PREFIX_O_APPEND, so the `Flags` in `FileChannel` is different from other targets.  Then failed[2] to cross compiling jdk12 for mips64el-linux-gnu

Re: Fail to cross compiling jdk12 for mips64el-linux-gnu target

2019-01-23 Thread David Holmes
effect the `UnixConstants` of src/java.base/unix/classes/sun/nio/fs/UnixConstants.java.template, for example, PREFIX_O_APPEND, so the `Flags` in `FileChannel` is different from other targets. Then failed[2] to cross compiling jdk12 for mips64el-linux-gnu target by following the document[3]. It's bee

Re: Fail to cross compiling jdk12 for mips64el-linux-gnu target

2019-01-23 Thread Ao Qi
[1], it > > will effect the `UnixConstants` of > > src/java.base/unix/classes/sun/nio/fs/UnixConstants.java.template, for > > example, PREFIX_O_APPEND, so the `Flags` in `FileChannel` is different > > from other targets. Then failed[2] to cross compiling jdk12 for > > mips64e

Re: Fail to cross compiling jdk12 for mips64el-linux-gnu target

2019-01-23 Thread Leslie Zhai
Hi David, Thanks for your kind response! You point out the root cause: executing a tool on the build platform (X86 host) using the newly compiled classes for the target platform (MIPS target) especially when the flags' macro is different. I will use workaround 1 before fix the root cause. R

Re: Fail to cross compiling jdk12 for mips64el-linux-gnu target

2019-01-23 Thread David Holmes
r example, PREFIX_O_APPEND, so the `Flags` in `FileChannel` is different from other targets.  Then failed[2] to cross compiling jdk12 for mips64el-linux-gnu target by following the document[3]. It's been quite a while since we built for a platform where the flags had different values, but it is supp

Fail to cross compiling jdk12 for mips64el-linux-gnu target

2019-01-23 Thread Leslie Zhai
led[2] to cross compiling jdk12 for mips64el-linux-gnu target by following the document[3]. Workaround 1: Only make hotspot, then scp build/linux-mips64el-normal-server-fastdebug/jdk/lib/server/libjvm.so to mips64el target machine, java version is able to work[4], but it needs to make imag

Re: (urgent) RFR: JDK-8157506: Disable bootcycle build when cross compiling

2016-05-21 Thread Mandy Chung
> On May 21, 2016, at 5:41 AM, Erik Joelsson wrote: > > We recently enabled a couple of cross compilation configurations in the main > PIT builds. These builds run bootcycle builds. The boot cycle build can > naturally not work when cross compiling, but the makefiles ar

Re: (urgent) RFR: JDK-8157506: Disable bootcycle build when cross compiling

2016-05-21 Thread Tim Bell
naturally not work when cross compiling, but the makefiles are currently not equipped to handle that. Bug: https://bugs.openjdk.java.net/browse/JDK-8157506 Patch: diff -r fa3dec0c2862 make/Main.gmk --- a/make/Main.gmk +++ b/make/Main.gmk @@ -302,9 +302,13 @@ BOOTCYCLE_TARGET := product-images

Re: (urgent) RFR: JDK-8157506: Disable bootcycle build when cross compiling

2016-05-21 Thread Alan Bateman
Looks okay to me. On 21/05/2016 13:41, Erik Joelsson wrote: We recently enabled a couple of cross compilation configurations in the main PIT builds. These builds run bootcycle builds. The boot cycle build can naturally not work when cross compiling, but the makefiles are currently not

(urgent) RFR: JDK-8157506: Disable bootcycle build when cross compiling

2016-05-21 Thread Erik Joelsson
We recently enabled a couple of cross compilation configurations in the main PIT builds. These builds run bootcycle builds. The boot cycle build can naturally not work when cross compiling, but the makefiles are currently not equipped to handle that. Bug: https://bugs.openjdk.java.net/browse

Re: Cross-compiling and the gen* native build tools

2014-02-04 Thread David Holmes
ing on Ubuntu 12.10. So we know, or already assume, that the value selected when compiling for linux_x86 will be valid when running on all linux_x86 platforms. This situation is the same regardless of platform, and regardless of if we're cross-compiling or not. And we also does not expect thes

Re: Cross-compiling and the gen* native build tools

2014-02-04 Thread Magnus Ihse Bursie
, or already assume, that the value selected when compiling for linux_x86 will be valid when running on all linux_x86 platforms. This situation is the same regardless of platform, and regardless of if we're cross-compiling or not. And we also does not expect these values to change as long as w

Re: Cross-compiling and the gen* native build tools

2014-02-04 Thread Magnus Ihse Bursie
extracting system constants, that might be a good idea, yes. I can't see any reason for why not a cross-compiling toolchain's preprocessor could be used in those cases, so that should be one way to get rid of the build compiler. Thanks for the suggestion! /Magnus

Re: Cross-compiling and the gen* native build tools

2014-02-03 Thread David Holmes
Hi Magnus, On 4/02/2014 12:13 AM, Magnus Ihse Bursie wrote: I just noticed this when replying to a mail to Volker, but I think this is worth a thread on it's own. There are three very similar build helpers that are compiler with BUILD_CC, i.e. the compiler for the build (not target) platform. T

Cross-compiling and the gen* native build tools

2014-02-03 Thread Magnus Ihse Bursie
I just noticed this when replying to a mail to Volker, but I think this is worth a thread on it's own. There are three very similar build helpers that are compiler with BUILD_CC, i.e. the compiler for the build (not target) platform. They are: jdk/src/solaris/native/sun/nio/fs/genUnixConstant

Re: Review Request: 8005855: build-infra: Remove -R flag when cross compiling

2013-01-22 Thread Tim Bell
Hi Erik: New webrev for this: http://cr.openjdk.java.net/~erikj/8005855/webrev.root.02/ I changed the sed to only remove the -R argument and made it conditional on cross compilation. Looks good. Thanks for the background! Tim A bit of background on this. The X_LIBS variable is created b

Re: Review Request: 8005855: build-infra: Remove -R flag when cross compiling

2013-01-22 Thread David Holmes
Okay. I can't attest to the accuracy of the sed command but I agree with the intent :) Though I'm not sure there still exists any place where we use X_LIBS if cross-compiling. Thanks, David On 22/01/2013 8:18 PM, Erik Joelsson wrote: New webrev for this: http://cr.openjdk.java.

Re: Review Request: 8005855: build-infra: Remove -R flag when cross compiling

2013-01-22 Thread Erik Joelsson
New webrev for this: http://cr.openjdk.java.net/~erikj/8005855/webrev.root.02/ I changed the sed to only remove the -R argument and made it conditional on cross compilation. A bit of background on this. The X_LIBS variable is created by autoconf by calling some special macros to locate libra

Re: Review Request: 8005855: build-infra: Remove -R flag when cross compiling

2013-01-09 Thread Erik Joelsson
8003958 fixes this for sizer generation yes, but there is also one library in CompileNativeLibraries that has X_LIBS on the link line. But I suppose we shouldn't fix it unless there is a problem with it. /Erik On 2013-01-09 03:56, David Holmes wrote: On 9/01/2013 5:56 AM, Kelly O'Hair wrote:

Re: Review Request: 8005855: build-infra: Remove -R flag when cross compiling

2013-01-08 Thread David Holmes
On 9/01/2013 5:56 AM, Kelly O'Hair wrote: I need more info on this, what is X_LIBS for, and why remove ALL -R options. IIRC Fredrik added this to deal with some binary difference detected on OSX. I don't know what these variables actually contain I always considered the -R options to be LD

Re: Review Request: 8005855: build-infra: Remove -R flag when cross compiling

2013-01-08 Thread Kelly O'Hair
I need more info on this, what is X_LIBS for, and why remove ALL -R options. I always considered the -R options to be LD options, not library specifications really. The -L and -l options are library specifications, but -R is just a path that gets baked into the .so for runtime access to the libr

Re: Review Request: 8005855: build-infra: Remove -R flag when cross compiling

2013-01-08 Thread Tim Bell
Hi Erik: Filter away -R flags from X_LIBS variable in configure. http://cr.openjdk.java.net/~erikj/8005855/webrev.root.01/ common/autoconf/libraries.m4: 143 X_LIBS=`$ECHO $X_LIBS | $SED 's/-R.*//g'` If I am reading this correctly, sed will delete everything from -R to end of line. Is that

Review Request: 8005855: build-infra: Remove -R flag when cross compiling

2013-01-08 Thread Erik Joelsson
Filter away -R flags from X_LIBS variable in configure. http://cr.openjdk.java.net/~erikj/8005855/webrev.root.01/

Re: RFR: 8002034 and 8001756 - FDS changes mainly re cross-compiling

2012-11-08 Thread BILL PITTORE
OBJCOPY changes look good. bill On 11/4/2012 5:32 PM, David Holmes wrote: Okay here's the final update :) http://cr.openjdk.java.net/~dholmes/8002034/webrev.03/ We now have a default objcopy when cross-compiling and I augmented the error message if no objcopy is found. These changes

Re: RFR: 8002034 and 8001756 - FDS changes mainly re cross-compiling

2012-11-08 Thread BILL PITTORE
INFO: ENABLE_FULL_DEBUG_SYMBOLS=0 Thanks, David -Dmitry On 2012-11-02 02:15, David Holmes wrote: Thanks for the review Dmitry. On 1/11/2012 10:02 PM, Dmitry Samersoff wrote: David,s if we use host /usr/bin/objcopy for cross compiling, changes looks good for me. ??? We don't use host /usr/bin/objcopy

Re: RFR: 8002034 and 8001756 - FDS changes mainly re cross-compiling

2012-11-08 Thread Gary Collins
Debug Symbols when cross-compiling >>>> >>>> The initial FDS work simply disables FDS when cross-compilation is >>>> involved. But we're now ready to deal with the cross-compilation case >>>> (and even if we weren't these changes would be fi

Re: RFR: 8002034 and 8001756 - FDS changes mainly re cross-compiling

2012-11-08 Thread Gary Collins
excludes a couple of the unnecessary > executions. > > Thanks, > David > > On 31/10/2012 5:29 PM, David Holmes wrote: >> http://cr.openjdk.java.net/~dholmes/8002034/webrev/ >> >> This mainly addresses >> >> JDK-8002034 Allow Full Debug Sy

hg: jdk8/build/jdk: 8002040: Allow Full Debug Symbols when cross-compiling

2012-11-07 Thread david . holmes
Changeset: 3717bcf9d7a7 Author:dholmes Date: 2012-11-07 23:12 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3717bcf9d7a7 8002040: Allow Full Debug Symbols when cross-compiling Reviewed-by: dcubed, erikj, tbell ! make/common/Defs-linux.gmk

Re: XS RFR: 8002040 Allow Full Debug Symbols when cross-compiling

2012-11-07 Thread Tim Bell
On 11/06/12 21:08, David Holmes wrote: webrev: http://cr.openjdk.java.net/~dholmes/8002040/webrev/ This is a simplified variant of the change just made to Hotspot. Instead of disabling FDS when cross-compiling we change the default location of objcopy, and just as with native compilation

Re: XS RFR: 8002040 Allow Full Debug Symbols when cross-compiling

2012-11-07 Thread Daniel D. Daugherty
On 11/6/12 10:08 PM, David Holmes wrote: webrev: http://cr.openjdk.java.net/~dholmes/8002040/webrev/ Thumbs up. make/common/Defs-linux.gmk No comments. This is a simplified variant of the change just made to Hotspot. Instead of disabling FDS when cross-compiling we change the default

Re: XS RFR: 8002040 Allow Full Debug Symbols when cross-compiling

2012-11-07 Thread Erik Joelsson
Looks good to me. /Erik On 2012-11-07 06:08, David Holmes wrote: webrev: http://cr.openjdk.java.net/~dholmes/8002040/webrev/ This is a simplified variant of the change just made to Hotspot. Instead of disabling FDS when cross-compiling we change the default location of objcopy, and just as

XS RFR: 8002040 Allow Full Debug Symbols when cross-compiling

2012-11-06 Thread David Holmes
webrev: http://cr.openjdk.java.net/~dholmes/8002040/webrev/ This is a simplified variant of the change just made to Hotspot. Instead of disabling FDS when cross-compiling we change the default location of objcopy, and just as with native compilation either the default objcopy is found or we

Re: RFR: 8002034 and 8001756 - FDS changes mainly re cross-compiling

2012-11-05 Thread David Holmes
ws/makefiles/defs.make nit line 135: space between 'times.We' Dan We now have a default objcopy when cross-compiling and I augmented the error message if no objcopy is found. These changes only affect the linux defs.make. Thanks, David On 2/11/2012 12:39 PM, David Holmes wrote: O

Re: RFR: 8002034 and 8001756 - FDS changes mainly re cross-compiling

2012-11-05 Thread Daniel D. Daugherty
at end of sentence. make/linux/makefiles/vm.make nit line 359: added extra blank line make/solaris/makefiles/defs.make nit line 113: space between 'times.We' make/windows/makefiles/defs.make nit line 135: space between 'times.We' Dan We now have a default obj

Re: RFR: 8002034 and 8001756 - FDS changes mainly re cross-compiling

2012-11-05 Thread Dmitry Samersoff
David, Looks good for me. -Dmitry On 2012-11-05 02:32, David Holmes wrote: > Okay here's the final update :) > > http://cr.openjdk.java.net/~dholmes/8002034/webrev.03/ > > We now have a default objcopy when cross-compiling and I augmented the > error message if no

Re: RFR: 8002034 and 8001756 - FDS changes mainly re cross-compiling

2012-11-05 Thread Erik Joelsson
Best version so far. /Erik On 2012-11-04 23:32, David Holmes wrote: Okay here's the final update :) http://cr.openjdk.java.net/~dholmes/8002034/webrev.03/ We now have a default objcopy when cross-compiling and I augmented the error message if no objcopy is found. These changes only a

Re: RFR: 8002034 and 8001756 - FDS changes mainly re cross-compiling

2012-11-04 Thread David Holmes
Okay here's the final update :) http://cr.openjdk.java.net/~dholmes/8002034/webrev.03/ We now have a default objcopy when cross-compiling and I augmented the error message if no objcopy is found. These changes only affect the linux defs.make. Thanks, David On 2/11/2012 12:39 PM,

Re: RFR: 8002034 and 8001756 - FDS changes mainly re cross-compiling

2012-11-04 Thread David Holmes
there any defaults? No. The makefiles know nothing about the toolsets for cross-compiling. We set CC, CPP, CXX using COMPILER_PATH which gets us to the cross tools, why not go for OBJCOPY as well? It may or may not exist. Is that worse than the current situation? Fair point, we could just

Re: RFR: 8002034 and 8001756 - FDS changes mainly re cross-compiling

2012-11-04 Thread Dmitry Samersoff
Sorry, (my eyes) I misread if >>>>>> >>>>>> As far as I understand, cross compilation require explicit >>>>>> ALT_OBJCOPY. >>>>> >>>>> Yes. >>>>> >>>>>> Is there any defaults?

Re: RFR: 8002034 and 8001756 - FDS changes mainly re cross-compiling

2012-11-02 Thread Dmitry Samersoff
gt;> As far as I understand, cross compilation require explicit ALT_OBJCOPY. >>> >>> Yes. >>> >>>> Is there any defaults? >>> >>> No. The makefiles know nothing about the toolsets for cross-compiling. >> We set CC, CPP, CXX using

Re: RFR: 8002034 and 8001756 - FDS changes mainly re cross-compiling

2012-11-01 Thread David Holmes
know nothing about the toolsets for cross-compiling. We set CC, CPP, CXX using COMPILER_PATH which gets us to the cross tools, why not go for OBJCOPY as well? It may or may not exist. Is that worse than the current situation? Fair point, we could just assume that when cross-compiling we find

Re: RFR: 8002034 and 8001756 - FDS changes mainly re cross-compiling

2012-11-01 Thread David Holmes
On 2/11/2012 8:49 AM, Dmitry Samersoff wrote: David, Sorry, (my eyes) I misread if As far as I understand, cross compilation require explicit ALT_OBJCOPY. Yes. Is there any defaults? No. The makefiles know nothing about the toolsets for cross-compiling. Does it make sense to warn if

Re: RFR: 8002034 and 8001756 - FDS changes mainly re cross-compiling

2012-11-01 Thread Dmitry Samersoff
/2012 10:02 PM, Dmitry Samersoff wrote: >> David,s >> >> if we use host /usr/bin/objcopy for cross compiling, >> changes looks good for me. > > ??? We don't use host /usr/bin/objcopy for cross-compiling that is why > DEF_OBJCOPY is only set when not cross-co

Re: RFR: 8002034 and 8001756 - FDS changes mainly re cross-compiling

2012-11-01 Thread David Holmes
va.net/~dholmes/8002034/webrev/ This mainly addresses JDK-8002034 Allow Full Debug Symbols when cross-compiling The initial FDS work simply disables FDS when cross-compilation is involved. But we're now ready to deal with the cross-compilation case (and even if we weren't these changes would b

Re: RFR: 8002034 and 8001756 - FDS changes mainly re cross-compiling

2012-11-01 Thread David Holmes
Thanks for the review Dmitry. On 1/11/2012 10:02 PM, Dmitry Samersoff wrote: David, if we use host /usr/bin/objcopy for cross compiling, changes looks good for me. ??? We don't use host /usr/bin/objcopy for cross-compiling that is why DEF_OBJCOPY is only set when not cross-compiling.

Re: RFR: 8002034 and 8001756 - FDS changes mainly re cross-compiling

2012-11-01 Thread Daniel D. Daugherty
id Holmes wrote: http://cr.openjdk.java.net/~dholmes/8002034/webrev/ This mainly addresses JDK-8002034 Allow Full Debug Symbols when cross-compiling The initial FDS work simply disables FDS when cross-compilation is involved. But we're now ready to deal with the cross-compilation case (an

Re: RFR: 8002034 and 8001756 - FDS changes mainly re cross-compiling

2012-11-01 Thread Dmitry Samersoff
David, if we use host /usr/bin/objcopy for cross compiling, changes looks good for me. -Dmitry On 2012-11-01 07:41, David Holmes wrote: > No takers so far - don't be shy, it's not a difficult one I promise :) > > Updated webrev: http://cr.openjdk.java.net/~dholme

Re: RFR: 8002034 and 8001756 - FDS changes mainly re cross-compiling

2012-11-01 Thread Erik Joelsson
excludes a couple of the unnecessary executions. Thanks, David On 31/10/2012 5:29 PM, David Holmes wrote: http://cr.openjdk.java.net/~dholmes/8002034/webrev/ This mainly addresses JDK-8002034 Allow Full Debug Symbols when cross-compiling The initial FDS work simply disables FDS when cross-comp

Re: RFR: 8002034 and 8001756 - FDS changes mainly re cross-compiling

2012-10-31 Thread David Holmes
ote: http://cr.openjdk.java.net/~dholmes/8002034/webrev/ This mainly addresses JDK-8002034 Allow Full Debug Symbols when cross-compiling The initial FDS work simply disables FDS when cross-compilation is involved. But we're now ready to deal with the cross-compilation case (and even if we weren't

RFR: 8002034 and 8001756 - FDS changes mainly re cross-compiling

2012-10-31 Thread David Holmes
http://cr.openjdk.java.net/~dholmes/8002034/webrev/ This mainly addresses JDK-8002034 Allow Full Debug Symbols when cross-compiling The initial FDS work simply disables FDS when cross-compilation is involved. But we're now ready to deal with the cross-compilation case (and even if we we

Re: Cross Compiling

2012-03-08 Thread David Holmes
On 9/03/2012 9:20 AM, David Holmes wrote: On 9/03/2012 3:40 AM, martin burtscher wrote: can anybody confirm, that cross compiling is working with make flags: CROSS_COMPILE_ARCH ALT_COMPILER_PATH? With confirm i mean tested and not just read in readme, because theres also a BUILD_HEADLESS_ONLY

Re: Cross Compiling

2012-03-08 Thread David Holmes
Martin, On 9/03/2012 3:40 AM, martin burtscher wrote: Hello, can anybody confirm, that cross compiling is working with make flags: CROSS_COMPILE_ARCH ALT_COMPILER_PATH? With confirm i mean tested and not just read in readme, because theres also a BUILD_HEADLESS_ONLY in the readme which

Cross Compiling

2012-03-08 Thread martin burtscher
Hello, can anybody confirm, that cross compiling is working with make flags: CROSS_COMPILE_ARCH ALT_COMPILER_PATH? With confirm i mean tested and not just read in readme, because theres also a BUILD_HEADLESS_ONLY in the readme which doesn't work. Thanks. Martin

Re: Cross Compiling for x86_64 on x86

2009-12-07 Thread Deepak Mathews
Hi, Thank you guys for your info. I will try to do what Christian said. Hope it works. Anyways if it does not work correctly then, it cannot be cross compiled I guess. Thanks a lot. Regards, Deepak On Mon, Dec 7, 2009 at 3:55 PM, Erik Trimble wrote: > Christian Thalinger wrote: > >> On Mon,

Re: Cross Compiling for x86_64 on x86

2009-12-07 Thread Erik Trimble
Christian Thalinger wrote: On Mon, 2009-12-07 at 10:39 +0100, Christian Thalinger wrote: There problem here is ADLC, which is part of the server compiler. Let me try to get it built for a 32-bit host... A really ugly (but possibly working) hack to build a full OpenJDK successfully wou

Re: Cross Compiling for x86_64 on x86

2009-12-07 Thread Christian Thalinger
On Mon, 2009-12-07 at 10:39 +0100, Christian Thalinger wrote: > There problem here is ADLC, which is part of the server compiler. Let > me try to get it built for a 32-bit host... A really ugly (but possibly working) hack to build a full OpenJDK successfully would be to copy a 32-bit adlc over th

Re: Cross Compiling for x86_64 on x86

2009-12-07 Thread Christian Thalinger
On Mon, 2009-12-07 at 14:55 +0530, Deepak Mathews wrote: > Can the building of OpenJDK made independant of the host machine. Or > does it run some programs which are dependant (like adlc) which will > make cross compilation impossible? > > > What about cross compiling for MI

Re: Cross Compiling for x86_64 on x86

2009-12-07 Thread David Holmes - Sun Microsystems
model = x86_64 os_arch = linux_x86 os_arch_model = linux_x86_64 lib_arch = amd64 otherwise they will be determined from the properties of the build machine. I don't know if anyone has tried this, but it is where I would start. Note that building 32-bit on 64-bit is not truly cross-compili

Re: Cross Compiling for x86_64 on x86

2009-12-07 Thread Deepak Mathews
which will make cross compilation impossible? What about cross compiling for MIPS or PPC from the same 32 bit host? Will this same VM problem be there for that also? Thanks. Deepak On Mon, Dec 7, 2009 at 2:35 PM, Vikram A wrote: > hi Deepak, > > Incomplete information, please also s

Re: Cross Compiling for x86_64 on x86

2009-12-07 Thread Vikram A
resending- adding the alias. On Mon, Dec 7, 2009 at 2:35 PM, Vikram A wrote: > hi Deepak, > > Incomplete information, please also specify the workspace you are trying to > build. Also, please share the errors generated. > Putting uname -a in the first mail itself helps alongwith appropriate cat

Re: Cross Compiling for x86_64 on x86

2009-12-06 Thread Deepak Mathews
Hi, Thank you Eric, for your quick reply. Sorry, I had forgot to mention the platform. It is Linux. Thanks. Deepak On Mon, Dec 7, 2009 at 12:16 PM, Erik Trimble wrote: > Deepak Mathews wrote: > >> Hi, >> >> I am trying to cross compile for x86 64 bit from a x86 32 bit host >> machine. >> >>

Re: Cross Compiling for x86_64 on x86

2009-12-06 Thread Erik Trimble
Deepak Mathews wrote: Hi, I am trying to cross compile for x86 64 bit from a x86 32 bit host machine. I am facing a lot of issues in this regard. Has anyone been able to successfully do this. Why is the target being linked against libjvm.so which is in the ALT_BOOTDIR on the host system.

Cross Compiling for x86_64 on x86

2009-12-06 Thread Deepak Mathews
Hi, I am trying to cross compile for x86 64 bit from a x86 32 bit host machine. I am facing a lot of issues in this regard. Has anyone been able to successfully do this. Why is the target being linked against libjvm.so which is in the ALT_BOOTDIR on the host system. Even if i fix that issue by