Re: Feedback on the New Build System

2013-03-14 Thread Andrew Hughes
- Original Message - > On 03/14/2013 08:58 AM, Alan Bateman wrote: > > On 14/03/2013 01:26, David Holmes wrote: > >> : > >> > >>> 3. -Werror is set for the SCTP native code causing the build to > >>> fail: > >>> > >>> Lots of stuff like: > >>> > >>> /home/andrew/projects/openjdk/upstream

Re: Feedback on the New Build System

2013-03-14 Thread Andrew Hughes
- Original Message - > On 14/03/2013 01:26, David Holmes wrote: > > : > > > >> 3. -Werror is set for the SCTP native code causing the build to > >> fail: > >> > >> Lots of stuff like: > >> > >> /home/andrew/projects/openjdk/upstream/jdk8/jdk/src/solaris/native/sun/nio/ch/sctp/SctpChannel

Re: Feedback on the New Build System

2013-03-14 Thread Chris Hegarty
On 03/14/2013 08:58 AM, Alan Bateman wrote: On 14/03/2013 01:26, David Holmes wrote: : 3. -Werror is set for the SCTP native code causing the build to fail: Lots of stuff like: /home/andrew/projects/openjdk/upstream/jdk8/jdk/src/solaris/native/sun/nio/ch/sctp/SctpChannelImpl.c:88:24: error:

Re: Feedback on the New Build System

2013-03-14 Thread Erik Joelsson
Hello Andrew, Thanks for the feedback! Adding in my view of things below. On 2013-03-13 17:16, Andrew Hughes wrote: I've just got my first build out of the new system using the main jdk8/jdk8 tree (b80) and so thought it was worth giving some feedback on the problems encountered and issues wi

Re: Feedback on the New Build System

2013-03-14 Thread Alan Bateman
On 14/03/2013 01:26, David Holmes wrote: : 3. -Werror is set for the SCTP native code causing the build to fail: Lots of stuff like: /home/andrew/projects/openjdk/upstream/jdk8/jdk/src/solaris/native/sun/nio/ch/sctp/SctpChannelImpl.c:88:24: error: unused parameter 'klass' [-Werror=unused-pa

Re: Feedback on the New Build System

2013-03-13 Thread David Holmes
Hi Andrew, On 14/03/2013 2:16 AM, Andrew Hughes wrote: I've just got my first build out of the new system using the main jdk8/jdk8 tree (b80) and so thought it was worth giving some feedback on the problems encountered and issues with the end result: 1. It took some time to work out how to g

Re: Feedback on the New Build System

2013-03-13 Thread Andrew Hughes
- Original Message - > On 3/13/13 7:35 PM, Andrew Hughes wrote: > > I still think it should be a configure option, which is the first > > place I looked. > > You'd usually use it if something interesting happens, like a build > failure, and > it's a you're 'not sure how it could have come

Re: Feedback on the New Build System

2013-03-13 Thread Mike Duigou
Ugh. effect -> affect. An unforgivable mistake. Mike On Mar 13 2013, at 12:18 , Mike Duigou wrote: > I generally agree that logging is something I want to tune dynamically. > Logging is one of the few things I prefer as an environment variable. > > As a compromise though perhaps a configure op

Re: Feedback on the New Build System

2013-03-13 Thread Mike Duigou
I generally agree that logging is something I want to tune dynamically. Logging is one of the few things I prefer as an environment variable. As a compromise though perhaps a configure option to adjust the default logging level might work. Still overridable via LOG but with a configurable defaul

Re: Feedback on the New Build System

2013-03-13 Thread Dalibor Topic
On 3/13/13 7:35 PM, Andrew Hughes wrote: > I still think it should be a configure option, which is the first place I > looked. You'd usually use it if something interesting happens, like a build failure, and it's a you're 'not sure how it could have come to this' situation, so in that case, h

Re: Feedback on the New Build System

2013-03-13 Thread Andrew Hughes
- Original Message - > On 03/13/2013 12:16 PM, Andrew Hughes wrote: > > 1. It took some time to work out how to get back to the usual > > 'noisy' build as the > > default seems to subdue all the useful output. VERBOSE=true broke > > the build when > > it tried to use 'true' as a Makefile

Re: Feedback on the New Build System

2013-03-13 Thread Omair Majid
On 03/13/2013 12:16 PM, Andrew Hughes wrote: > 1. It took some time to work out how to get back to the usual 'noisy' build > as the > default seems to subdue all the useful output. VERBOSE=true broke the build > when > it tried to use 'true' as a Makefile target. It turns out the solution is

Feedback on the New Build System

2013-03-13 Thread Andrew Hughes
I've just got my first build out of the new system using the main jdk8/jdk8 tree (b80) and so thought it was worth giving some feedback on the problems encountered and issues with the end result: 1. It took some time to work out how to get back to the usual 'noisy' build as the default seems t