Re: Fixes for sanity-compiler-gcc and detection of linux variant

On Nov 12, 2010, at 3:14 PM, Mike Duigou wrote: On Nov 6 2010, at 07:07 , David Holmes wrote: 6998016: Incorrect ifdef nesting in sane-gcc-compiler rule http://cr.openjdk.java.net/~mduigou/6998016.0/webrev/ In Defs-linux.gmk I must be missing something: ifneq "$(origin ALT_GCC29_COMPILER

Re: Fixes for sanity-compiler-gcc and detection of linux variant

On Nov 6 2010, at 07:07 , David Holmes wrote: >> 6998016: Incorrect ifdef nesting in sane-gcc-compiler rule >> >> http://cr.openjdk.java.net/~mduigou/6998016.0/webrev/ > > In Defs-linux.gmk I must be missing something: > > ifneq "$(origin ALT_GCC29_COMPILER_PATH)" "undefined" > > and > > ifd

Re: Fixes for sanity-compiler-gcc and detection of linux variant

Hi Mike, On 6/11/2010 9:07 AM, Mike Duigou wrote: Hi all; Two minor fixes for review: 6998014: Use /etc/lsb-release, when available, to detect linux variant and version Can't comment on this part. 6998016: Incorrect ifdef nesting in sane-gcc-compiler rule http://cr.openjdk.java.net/~mdui

Fixes for sanity-compiler-gcc and detection of linux variant

Hi all; Two minor fixes for review: 6998014: Use /etc/lsb-release, when available, to detect linux variant and version 6998016: Incorrect ifdef nesting in sane-gcc-compiler rule http://cr.openjdk.java.net/~mduigou/6998016.0/webrev/ Thanks! Mike