On Wed, 4 Nov 2020 12:59:24 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
> Current submit workflow omits `hs_err*.log` and `replay*.log` files, because > zip matches the paths, and so only the hs_errs/replays in the current dir are > picked up (and there are none). It should be preceded with `*` to match files > in subdirs. Incidentally, this is why `*.jtr` match works. > > Observe: > > $ mkdir 1/2 -p > $ touch 1/2/hs_err_213123.log > $ zip -r9 test.zip . -i hs_err* > zip warning: zip file empty > $ zip -r9 test.zip . -i */hs_err* > adding: 1/2/hs_err_213123.log (stored 0%) > > This was introduced in the initial implementation in JDK-8255352. > > Additional testing: > - [x] Observing current Windows failures package hs_err into archive This pull request has now been integrated. Changeset: 61c92470 Author: Aleksey Shipilev <sh...@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/61c92470 Stats: 8 lines in 1 file changed: 0 ins; 0 del; 8 mod 8255895: Submit workflow artifacts miss hs_errs/replays due to ZIP include mismatch Reviewed-by: erikj ------------- PR: https://git.openjdk.java.net/jdk/pull/1055
