RE: JDK 14 RFR: 8216354: Syntax error in toolchain_windows.m4

2019-09-14 Thread Langer, Christoph
> -Simon > > > > > Best regards > > Christoph > > > >> -Original Message- > >> From: build-dev On Behalf Of > Erik > >> Joelsson > >> Sent: Donnerstag, 12. September 2019 17:10 > >> To: David Holmes ; Simon Tooke >

Re: JDK 14 RFR: 8216354: Syntax error in toolchain_windows.m4

2019-09-12 Thread David Holmes
Erik, Simon, Thanks for clarifying things. It would have been somewhat clearer if a new bug for the space-in-path problem has been filed rather then reopening the existing issue. Cheers, David On 13/09/2019 1:10 am, Erik Joelsson wrote: Hello David, The initial report was about this constr

Re: JDK 14 RFR: 8216354: Syntax error in toolchain_windows.m4

2019-09-12 Thread Simon Tooke
- >> From: build-dev On Behalf Of Erik >> Joelsson >> Sent: Donnerstag, 12. September 2019 17:10 >> To: David Holmes ; Simon Tooke >> ; build-dev >> Subject: Re: JDK 14 RFR: 8216354: Syntax error in toolchain_windows.m4 >> >> Hello David, >&

RE: JDK 14 RFR: 8216354: Syntax error in toolchain_windows.m4

2019-09-12 Thread Langer, Christoph
Simon Tooke > ; build-dev > Subject: Re: JDK 14 RFR: 8216354: Syntax error in toolchain_windows.m4 > > Hello David, > > The initial report was about this construct not working at all, as Bash > will not expand wildcards inside of quotes: > > "$with_ucrt_dll_dir/*.dl

Re: JDK 14 RFR: 8216354: Syntax error in toolchain_windows.m4

2019-09-12 Thread Erik Joelsson
Hello David, The initial report was about this construct not working at all, as Bash will not expand wildcards inside of quotes: "$with_ucrt_dll_dir/*.dll" In 13 I changed that to remove the quotes to make the statement work at all. The drawback then, as Simon pointed out, was that if $with

Re: JDK 14 RFR: 8216354: Syntax error in toolchain_windows.m4

2019-09-12 Thread Simon Tooke
On 9/11/2019 6:07 PM, David Holmes wrote: > Hi Simon, Erik, > > I'm a bit confused. Initially 8216354 was reported as already being > fixed by 8215445. But the fix proposed here actually reverts a change > from 8215445 which means that far from fixing this issue, 8215445 > actually introduced it

Re: JDK 14 RFR: 8216354: Syntax error in toolchain_windows.m4

2019-09-11 Thread David Holmes
Hi Simon, Erik, I'm a bit confused. Initially 8216354 was reported as already being fixed by 8215445. But the fix proposed here actually reverts a change from 8215445 which means that far from fixing this issue, 8215445 actually introduced it - correct? But 8215445 was only fixed in 13 - no

Re: JDK 14 RFR: 8216354: Syntax error in toolchain_windows.m4

2019-09-11 Thread Erik Joelsson
Looks good. /Erik On 2019-09-11 10:55, Simon Tooke wrote: This is a trivial fix that has been sitting around since JDK8. At one time, 8216354 was marked "won't fix", but I've seen people (including myself) run up against this issue enough that I think it should be addressed.  It's been reopene

JDK 14 RFR: 8216354: Syntax error in toolchain_windows.m4

2019-09-11 Thread Simon Tooke
This is a trivial fix that has been sitting around since JDK8.  At one time, 8216354 was marked "won't fix", but I've seen people (including myself) run up against this issue enough that I think it should be addressed.  It's been reopened, and I have a webrev ready that I've tested in the jdk repo