Re: Please review changes for JDK-8012975: Remove rhino from jdk8

2013-05-13 Thread Alan Bateman
On 13/05/2013 16:40, A. Sundararajan wrote: I agree that it is better to remove com.sun.script.util package as well. It is not used elsewhere and was never declared as supported API. I've removed the same and re-generated webrev. http://cr.openjdk.java.net/~sundar/8012975/webrev.03/ I ran NEW

Re: Please review changes for JDK-8012975: Remove rhino from jdk8

2013-05-13 Thread A. Sundararajan
I agree that it is better to remove com.sun.script.util package as well. It is not used elsewhere and was never declared as supported API. I've removed the same and re-generated webrev. http://cr.openjdk.java.net/~sundar/8012975/webrev.03/ I ran NEWBUILD=false as well as NEWBUILD=true to make

Re: Please review changes for JDK-8012975: Remove rhino from jdk8

2013-05-13 Thread Alan Bateman
On 13/05/2013 13:14, A. Sundararajan wrote: Incorporated changes as suggested. Uploaded webrev for historical purpose: http://cr.openjdk.java.net/~sundar/8012975/webrev.02/ PS. I am going ahead with push.. Thanks for fixing up refs.allowed, that one looks fine okay. Did you decide to keep c

Re: Please review changes for JDK-8012975: Remove rhino from jdk8

2013-05-13 Thread A. Sundararajan
Incorporated changes as suggested. Uploaded webrev for historical purpose: http://cr.openjdk.java.net/~sundar/8012975/webrev.02/ PS. I am going ahead with push.. Thanks -Sundar On Friday 10 May 2013 06:17 PM, A. Sundararajan wrote: Okay, thanks. com.sun.script.util is not supported API (no CCC

Re: Please review changes for JDK-8012975: Remove rhino from jdk8

2013-05-10 Thread Tim Bell
Hi Sundar Looks like you have resolved the subtleties of profiles with Alan. The rest looks good to me. Tim On 05/10/13 05:47 AM, A. Sundararajan wrote: Okay, thanks. com.sun.script.util is not supported API (no CCC done for it in the past). I'll remove it as suggested and run "make profile

Re: Please review changes for JDK-8012975: Remove rhino from jdk8

2013-05-10 Thread A. Sundararajan
Okay, thanks. com.sun.script.util is not supported API (no CCC done for it in the past). I'll remove it as suggested and run "make profiles" to check Thanks -Sundar On Friday 10 May 2013 04:09 PM, Alan Bateman wrote: On 10/05/2013 11:23, A. Sundararajan wrote: com/sun/script/util is generic u

Re: Please review changes for JDK-8012975: Remove rhino from jdk8

2013-05-10 Thread Alan Bateman
On 10/05/2013 11:23, A. Sundararajan wrote: com/sun/script/util is generic utility package for script engine implementations. Only com/sun/script/javascript package is being removed. Since we include javax/script for profile 3, should we also include com/sun/script/util ? Is com.sun.script.util

Re: Please review changes for JDK-8012975: Remove rhino from jdk8

2013-05-10 Thread A. Sundararajan
com/sun/script/util is generic utility package for script engine implementations. Only com/sun/script/javascript package is being removed. Since we include javax/script for profile 3, should we also include com/sun/script/util ? On refs.allowed, I'll remove it. How should I check this? Thanks

Re: Please review changes for JDK-8012975: Remove rhino from jdk8

2013-05-10 Thread Alan Bateman
On 10/05/2013 10:26, A. Sundararajan wrote: Please review the updated webrev @ http://cr.openjdk.java.net/~sundar/8012975/webrev.01/ Thanks -Sundar PROFILE_3_RTJAR_INCLUDE_PACKAGES needs to have com/sun/script removed. refs.allowed isn't quite right, the last line needs to be removed comple

Re: Please review changes for JDK-8012975: Remove rhino from jdk8

2013-05-10 Thread A. Sundararajan
Please review the updated webrev @ http://cr.openjdk.java.net/~sundar/8012975/webrev.01/ Thanks -Sundar On Friday 03 May 2013 02:56 PM, Alan Bateman wrote: On 03/05/2013 07:47, A. Sundararajan wrote: Thanks. Looks like the first one has not been removed. But second one was removed: hg stat

Re: Please review changes for JDK-8012975: Remove rhino from jdk8

2013-05-03 Thread Alan Bateman
On 03/05/2013 07:47, A. Sundararajan wrote: Thanks. Looks like the first one has not been removed. But second one was removed: hg stat shows R make/sun/org/mozilla/javascript/Makefile (also the webrev shows it as removed). Perhaps patch does not take care of deleted files?? I am not sure. A

Re: Please review changes for JDK-8012975: Remove rhino from jdk8

2013-05-02 Thread A. Sundararajan
On Friday 03 May 2013 11:53 AM, Tim Bell wrote: On 05/ 2/13 01:24 PM, I wrote: Hi Sundar: Oracle JDK includes Rhino based javax.script implementation (which lives mostly in "closed" code). Rhino is being removed from Oracle JDK builds and there are the changes to the jdk open repository as w

Re: Please review changes for JDK-8012975: Remove rhino from jdk8

2013-05-02 Thread Tim Bell
On 05/ 2/13 01:24 PM, I wrote: Hi Sundar: Oracle JDK includes Rhino based javax.script implementation (which lives mostly in "closed" code). Rhino is being removed from Oracle JDK builds and there are the changes to the jdk open repository as well like com.sun.script.javascript package, makef

Re: Please review changes for JDK-8012975: Remove rhino from jdk8

2013-05-02 Thread Tim Bell
Hi Sundar: Oracle JDK includes Rhino based javax.script implementation (which lives mostly in "closed" code). Rhino is being removed from Oracle JDK builds and there are the changes to the jdk open repository as well like com.sun.script.javascript package, makefiles etc. Please review the ope

Please review changes for JDK-8012975: Remove rhino from jdk8

2013-05-02 Thread A. Sundararajan
Hi, Oracle JDK includes Rhino based javax.script implementation (which lives mostly in "closed" code). Rhino is being removed from Oracle JDK builds and there are the changes to the jdk open repository as well like com.sun.script.javascript package, makefiles etc. Please review the open jdk c

Re: Please review changes for JDK-8012975: Remove rhino from jdk8

2013-05-02 Thread Alan Bateman
On 02/05/2013 17:41, A. Sundararajan wrote: Hi, Oracle JDK includes Rhino based javax.script implementation (which lives mostly in "closed" code). Rhino is being removed from Oracle JDK builds and there are the changes to the jdk open repository as well like com.sun.script.javascript package,