Re: RFR(XS): 8214063: [AIX] Disable symbol visibility flags

2018-12-04 Thread Adam Farley8
IBM Runtimes > > > > P.S. I approve the change too. ;) > > > > > > Volker Simonis wrote on 29/11/2018 11:54:33: > > > > > From: Volker Simonis > > > To: Magnus Ihse Bursie > > > Cc: build-dev , ppc-aix-port- > > > d...@openj

Re: RFR(XS): 8214063: [AIX] Disable symbol visibility flags

2018-12-04 Thread Volker Simonis
is wrote on 29/11/2018 11:54:33: > > > From: Volker Simonis > > To: Magnus Ihse Bursie > > Cc: build-dev , ppc-aix-port- > > d...@openjdk.java.net, adam.far...@uk.ibm.com > > Date: 29/11/2018 11:54 > > Subject: Re: RFR(XS): 8214063: [AIX] Dis

Re: RFR(XS): 8214063: [AIX] Disable symbol visibility flags

2018-11-29 Thread Adam Farley8
approve the change too. ;) Volker Simonis wrote on 29/11/2018 11:54:33: > From: Volker Simonis > To: Magnus Ihse Bursie > Cc: build-dev , ppc-aix-port- > d...@openjdk.java.net, adam.far...@uk.ibm.com > Date: 29/11/2018 11:54 > Subject: Re: RFR(XS): 8214063: [AIX] Disable

Re: RFR(XS): 8214063: [AIX] Disable symbol visibility flags

2018-11-29 Thread Volker Simonis
On Thu, Nov 29, 2018 at 12:20 PM Magnus Ihse Bursie wrote: > > On 2018-11-27 16:33, Volker Simonis wrote: > > > Hi, > > > > can I please have a review for the following trivial change which > > simply disables the symbol visibility flags on AIX: > > > >

Re: RFR(XS): 8214063: [AIX] Disable symbol visibility flags

2018-11-29 Thread Magnus Ihse Bursie
On 2018-11-27 16:33, Volker Simonis wrote: Hi, can I please have a review for the following trivial change which simply disables the symbol visibility flags on AIX: http://cr.openjdk.java.net/~simonis/webrevs/2018/8214063/ https://bugs.openjdk.java.net/browse/JDK-8214063 Looks good to me. I

RE: RFR(XS): 8214063: [AIX] Disable symbol visibility flags

2018-11-28 Thread Baesken, Matthias
openjdk.java.net>; ppc-aix-port-...@openjdk.java.net > Cc: adam.far...@uk.ibm.com > Subject: RE: RFR(XS): 8214063: [AIX] Disable symbol visibility flags > > > Change "8202322: AIX: symbol visibility flags not support on xlc 12.1" > > [1] blindly introduced these fla

Re: RFR(XS): 8214063: [AIX] Disable symbol visibility flags

2018-11-27 Thread Erik Joelsson
Looks ok to me. /Erik On 2018-11-27 07:33, Volker Simonis wrote: Hi, can I please have a review for the following trivial change which simply disables the symbol visibility flags on AIX: http://cr.openjdk.java.net/~simonis/webrevs/2018/8214063/

Re: RFR(XS): 8214063: [AIX] Disable symbol visibility flags

2018-11-27 Thread Thomas Stüfe
On Tue, Nov 27, 2018 at 4:35 PM Volker Simonis wrote: > > Hi, > > can I please have a review for the following trivial change which > simply disables the symbol visibility flags on AIX: > > http://cr.openjdk.java.net/~simonis/webrevs/2018/8214063/ >

Re: RFR(XS): 8214063: [AIX] Disable symbol visibility flags

2018-11-27 Thread Volker Simonis
On Tue, Nov 27, 2018 at 4:56 PM Baesken, Matthias wrote: > > > Change "8202322: AIX: symbol visibility flags not support on xlc 12.1" > > [1] blindly introduced these flags for all xlC compiler versions > > > Hello, probably you did not look correctly at my change 8202322 . > > It did NOT

RE: RFR(XS): 8214063: [AIX] Disable symbol visibility flags

2018-11-27 Thread Baesken, Matthias
> Change "8202322: AIX: symbol visibility flags not support on xlc 12.1" > [1] blindly introduced these flags for all xlC compiler versions > Hello, probably you did not look correctly at my change 8202322 . It did NOT "blindly" introduce visibility flags for all xlC compilers, but