Hi Severin,
Looks good to me.
Thanks,
Sharath (not a Reviewer)
-Original Message-
From: Severin Gehwolf [mailto:sgehw...@redhat.com]
Sent: Friday, September 14, 2018 7:04 PM
To: build-dev; serviceability-dev
Subject: RFR: 8210647: libsaproc is being compiled without optimization.
Hi,
A fix is waiting for review: https://bugs.openjdk.java.net/browse/JDK-8210836
Best Regards, Thomas
On Tue, Sep 18, 2018 at 5:09 PM, Anthony Scarpino
wrote:
> I encountered this too when I build with ‘make’; however if I build through
> JIB the error didn’t occur.
>
> Tony
>
>> On Sep 18, 2018,
I encountered this too when I build with ‘make’; however if I build through JIB
the error didn’t occur.
Tony
> On Sep 18, 2018, at 2:08 AM, Thomas Stüfe wrote:
>
> Hi Severin,
>
> I get reproducable build errors with your fix on my machine (Ubuntu 16.4).
>
> When I build release (no special
Hi Severin,
On Tue, Sep 18, 2018 at 11:24 AM, Severin Gehwolf wrote:
> Hi Thomas,
>
> On Tue, 2018-09-18 at 11:08 +0200, Thomas Stüfe wrote:
>> Hi Severin,
>>
>> I get reproducable build errors with your fix on my machine (Ubuntu 16.4).
>>
>> When I build release (no special build options), I get
Hi Thomas,
On Tue, 2018-09-18 at 11:08 +0200, Thomas Stüfe wrote:
> Hi Severin,
>
> I get reproducable build errors with your fix on my machine (Ubuntu 16.4).
>
> When I build release (no special build options), I get:
>
> /shared/projects/openjdk/jdk-jdk/source/src/jdk.hotspot.agent/linux/nati
Hi Severin,
I get reproducable build errors with your fix on my machine (Ubuntu 16.4).
When I build release (no special build options), I get:
/shared/projects/openjdk/jdk-jdk/source/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c:
In function ‘read_exec_segments’:
/shared/projects/openjd
Looks good to me.
Thanks,
Jini (Not a (R)eviewer)
On 9/14/2018 7:03 PM, Severin Gehwolf wrote:
Hi,
Could I please get a review of this one-liner fix. It changes
optimization of libsaproc from -O0 to -O3 (as per Magnus' suggestion).
I've run servicability tests and haven't seen any new failures
Looks good to me.
/Erik
On 2018-09-14 06:33, Severin Gehwolf wrote:
Hi,
Could I please get a review of this one-liner fix. It changes
optimization of libsaproc from -O0 to -O3 (as per Magnus' suggestion).
I've run servicability tests and haven't seen any new failures.
Thoughts?
Bug: https://
