led always for LIB_JVM).
Best regards, Matthias
From: Baesken, Matthias
Sent: Freitag, 17. Januar 2020 12:44
To: Magnus Ihse Bursie ; David
Holmes
; 'build-dev@openjdk.java.net' ; 'hotspot-...@openjdk.java.net'
Subject: RE: RFR: 8236714: enable link-time section-gc for linux to
remove
u
Thanks for the review !
Erik, are you fine with the latest change too ?
Best regards, Matthias
> On 2020-01-24 10:27, Baesken, Matthias wrote:
> > Hi Erik, thanks for the comments, new webrev :
> >
> > http://cr.openjdk.java.net/~mbaesken/webrevs/8236714.7/
> Looks good to me. Sorry for not
; 'hotspot-...@openjdk.java.net'
Subject: RE: RFR: 8236714: enable link-time section-gc for linux to
remove
unused code
* Matthias: Have a look at some recently added option to get an
indication of the best practice in adding new options. There are some
ways to
easily make this inc
be set to enable the link time section gc .
> >>> Exception is linuxs390x where we already have the feature enabled
> (and
> >> keep it enabled always for LIB_JVM).
> >>> Best regards, Matthias
> >>>
> >>>
> >>>
> >>> F
; 'hotspot-...@openjdk.java.net'
Subject: RE: RFR: 8236714: enable link-time section-gc for linux to remove
unused code
* Matthias: Have a look at some recently added option to get an
indication of the best practice in adding new options. There are some ways to
easily make this incorrect
Hi Magnus, d
: Baesken, Matthias
> > Sent: Freitag, 17. Januar 2020 12:44
> > To: Magnus Ihse Bursie ; David Holmes
> ; 'build-dev@openjdk.java.net' d...@openjdk.java.net>; 'hotspot-...@openjdk.java.net' d...@openjdk.java.net>
> > Subject: RE: RFR: 8236714: enable link-time section-
Hi Erik, okay I'll check that .
I had the impression I would have ordering issues of the m4 files and how they
end up in the generated-configure.sh but looks like that’s not the case .
Best regards, Matthias
>
> Hello Matthias,
>
> You can keep the setting up of all the flags in
Ihse Bursie ; David Holmes
; 'build-dev@openjdk.java.net' ;
'hotspot-...@openjdk.java.net'
Subject: RE: RFR: 8236714: enable link-time section-gc for linux to remove
unused code
* Matthias: Have a look at some recently added option to get an indication
of the best practice in adding
(and keep
it enabled always for LIB_JVM).
Best regards, Matthias
From: Baesken, Matthias
Sent: Freitag, 17. Januar 2020 12:44
To: Magnus Ihse Bursie ; David Holmes
; 'build-dev@openjdk.java.net'
; 'hotspot-...@openjdk.java.net'
Subject: RE: RFR: 8236714: enable link-time section-gc for linux
* Matthias: Have a look at some recently added option to get an indication
of the best practice in adding new options. There are some ways to easily make
this incorrect
Hi Magnus, do you have a good/”best practice” example (not that I catch a bad
one ) ?
Best regards, Matthias
On 2020-01-16 10:30, David Holmes wrote:
Hi Matthias,
On 16/01/2020 6:10 pm, Baesken, Matthias wrote:
Hi David, sure we can introduce a way to switch this on/off.
Thanks.
There is already something similar for the link-time optimization
(flto) , see the feature
JvmFeatures.gmk
180 ifeq
Hi Matthias,
On 16/01/2020 6:10 pm, Baesken, Matthias wrote:
Hi David, sure we can introduce a way to switch this on/off.
Thanks.
There is already something similar for the link-time optimization (flto) , see
the feature
JvmFeatures.gmk
180 ifeq ($(call check-jvm-feature, link-time-opt),
Hi David, sure we can introduce a way to switch this on/off.
There is already something similar for the link-time optimization (flto) , see
the feature
JvmFeatures.gmk
180 ifeq ($(call check-jvm-feature, link-time-opt), true)
190 ifeq ($(call check-jvm-feature, link-time-opt), false)
Hi Matthias,
I have reservations about turning this on by default and with no way to
control it. This seems like it should be something you have to opt-in to
initially while we gain some experience with it and ensure there are no
unexpected side-effects. After that it could be enabled by
Hi Erik, I did not notice slowdowns in our night makes .
Looking at a specific test machine I use (x86_64, build JOBS hardwired set
to 12 ) I get around 6 minutes build time with and without the feature .
( but you have to take into account that the link-time section-gc on
Given the discussion regarding lto on hotspot and the extreme increased
build time, have you noticed any difference in build times with this patch?
/Erik
On 2020-01-15 00:27, Baesken, Matthias wrote:
Hi Erik, thanks for the review and for forwarding , you are correct
corelibs-dev is
Hi Erik, thanks for the review and for forwarding , you are correct
corelibs-dev is probably interested in this as well .
Best regards, Matthias
> (adding core-libs-dev)
>
> Change looks good to me, but would like input from at least someone in
> core-libs.
>
> /Erik
>
> On 2020-01-14
(adding core-libs-dev)
Change looks good to me, but would like input from at least someone in
core-libs.
/Erik
On 2020-01-14 06:07, Baesken, Matthias wrote:
Hello, the following change enables the link-time section-gc for linux .
gcc and ld support enabling "garbage collection" of unused
18 matches
Mail list logo
