RE: RFR: 8241996: on linux set full relro in the linker flags

2020-04-02 Thread Baesken, Matthias
Thanks for the review ! -Original Message- From: Erik Joelsson Sent: Donnerstag, 2. April 2020 15:31 To: Baesken, Matthias ; 'hotspot-...@openjdk.java.net' ; 'build-dev@openjdk.java.net' Subject: Re: RFR: 8241996: on linux set full relro in the linker flags Looks good to me. /Erik

Re: RFR: 8241996: on linux set full relro in the linker flags

2020-04-02 Thread Erik Joelsson
Looks good to me. /Erik On 2020-04-02 00:41, Baesken, Matthias wrote: Hi Erik, that's a good point . New webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8241996.1/ Best regards, Matthias Hello Matthias, We are currently setting -z now for slowdebug builds. That should be removed

RE: RFR: 8241996: on linux set full relro in the linker flags

2020-04-02 Thread Baesken, Matthias
Hi Erik, that's a good point . New webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8241996.1/ Best regards, Matthias > Hello Matthias, > > We are currently setting -z now for slowdebug builds. That should be > removed if it's now set by default for all configs.

Re: RFR: 8241996: on linux set full relro in the linker flags

2020-04-01 Thread Erik Joelsson
Hello Matthias, We are currently setting -z now for slowdebug builds. That should be removed if it's now set by default for all configs. /Erik On 2020-04-01 06:35, Baesken, Matthias wrote: Hello, please review this binary hardening related change. To improve binary hardening, we should

Re: RFR: 8241996: on linux set full relro in the linker flags

2020-04-01 Thread Claes Redestad
Hi, I took this for a spin on my setup, and see a ~500k increase in both instructions and cycles - I guess one of your runs saw more interference than the other. From a startup performance point of view the advertised cost seems more or less negligible. (For context we've optimized away 10M