Re: RFR: JDK 11 P1: 8209806: API docs should be updated to refer to javase11

2018-08-21 Thread Tim Bell
Jon: Looks good to me as well. Tim On 08/21/18 12:00, Lance Andersen wrote: looks fine Jon On Aug 21, 2018, at 2:58 PM, Jonathan Gibbons wrote: Please review a simple high priority fix for JDK 11 that updates the link in the bottom of each page of the generated API docs. Instead of simp

Re: RFR: JDK 11 P1: 8209806: API docs should be updated to refer to javase11

2018-08-21 Thread Lance Andersen
looks fine Jon > On Aug 21, 2018, at 2:58 PM, Jonathan Gibbons > wrote: > > Please review a simple high priority fix for JDK 11 that updates the link in > the bottom of each page of the generated API docs. > > Instead of simply changing "10" to "11", the fix is to use the macro > $(VERSION_NU

RE: RFR: JDK 11 P1: 8209806: API docs should be updated to refer to javase11

2018-08-21 Thread Iris Clark
Looks good to me. iris -Original Message- From: Jonathan Gibbons Sent: Tuesday, August 21, 2018 11:58 AM To: build-dev@openjdk.java.net Subject: RFR: JDK 11 P1: 8209806: API docs should be updated to refer to javase11 Please review a simple high priority fix for JDK 11 that updates the

Re: RFR: JDK 11 P1: 8209806: API docs should be updated to refer to javase11

2018-08-21 Thread joe darcy
+1 -Joe On 8/21/2018 11:58 AM, Jonathan Gibbons wrote: Please review a simple high priority fix for JDK 11 that updates the link in the bottom of each page of the generated API docs. Instead of simply changing "10" to "11", the fix is to use the macro $(VERSION_NUMBER) instead, in line with