Re: RFR [XS] : jspawnhelper build settings cleanup

2017-02-09 Thread Erik Joelsson
* Baesken, Matthias ; build-dev@openjdk.java.net *Cc:* Langer, Christoph *Subject:* Re: RFR [XS] : jspawnhelper build settings cleanup Hello Matthias, Thanks for taking this on! You can still remove "INCLUDE_FILES := jspawnhelper.c". Another thing that struck me when looking at this i

RE: RFR [XS] : jspawnhelper build settings cleanup

2017-02-09 Thread Baesken, Matthias
o into another bug. Thanks and best regards, Matthias From: Erik Joelsson [mailto:erik.joels...@oracle.com] Sent: Mittwoch, 8. Februar 2017 11:11 To: Baesken, Matthias ; build-dev@openjdk.java.net Cc: Langer, Christoph Subject: Re: RFR [XS] : jspawnhelper build settings cleanup Hello Ma

Re: RFR [XS] : jspawnhelper build settings cleanup

2017-02-08 Thread Erik Joelsson
Hello Matthias, Thanks for taking this on! You can still remove "INCLUDE_FILES := jspawnhelper.c". Another thing that struck me when looking at this is the inconsistency of sometimes using $(MODULE) and sometimes explicitly using java.base in the paths. I think $(MODULE) is better in this con