8215296: do not disable c99 on Solaris - was :RE: disabled c99 in Solaris builds

2018-12-12 Thread Baesken, Matthias
; David Holmes > ; Erik Joelsson ; > build-dev@openjdk.java.net > Subject: Re: disabled c99 in Solaris builds > > > On Dec 12, 2018, at 9:11 AM, Magnus Ihse Bursie > wrote: > > > > > > > > On 2018-12-12 14:29, Baesken, Matthias wrote: > >>

Re: disabled c99 in Solaris builds

2018-12-12 Thread Kim Barrett
> On Dec 12, 2018, at 9:11 AM, Magnus Ihse Bursie > wrote: > > > > On 2018-12-12 14:29, Baesken, Matthias wrote: >>> I'd recommend a separate change to remove the -xc99=%none%. That's >>> trivial and can be done immediately, to the benefit of everyone. Getting >>> C++14 working is not

Re: disabled c99 in Solaris builds

2018-12-12 Thread Kim Barrett
> On Dec 12, 2018, at 8:21 AM, Magnus Ihse Bursie > wrote: > > On 2018-12-12 09:24, Baesken, Matthias wrote: >>> FWIW, in my in-development patch set for JEP 347 >>> (https://bugs.openjdk.java.net/browse/JDK-8208089) >>> >>> the -xc99=%none% option has been removed and -std=c99 added (for C

Re: disabled c99 in Solaris builds

2018-12-12 Thread Magnus Ihse Bursie
2018 14:22 To: Baesken, Matthias ; David Holmes ; Erik Joelsson ; 'build-dev@openjdk.java.net' ; Kim Barrett Subject: Re: disabled c99 in Solaris builds On 2018-12-12 09:24, Baesken, Matthias wrote: FWIW, in my in-development patch set for JEP 347 (https://bugs.openjdk.java.net/browse/JDK-8208089

RE: disabled c99 in Solaris builds

2018-12-12 Thread Baesken, Matthias
> > /Magnus > > > > Best regards, Matthias > > > > > >> -Original Message- > >> From: David Holmes > >> Sent: Dienstag, 11. Dezember 2018 23:16 > >> To: Erik Joelsson ; Baesken, Matthias > >> ; 'build-dev@openjdk.

Re: disabled c99 in Solaris builds

2018-12-12 Thread Magnus Ihse Bursie
: disabled c99 in Solaris builds On 12/12/2018 3:27 am, Erik Joelsson wrote: Hello, I do not know why this flag was introduced, but it has been there for a long time. In JDK7 it's listed in jdk/make/common/Defs-solaris.gmk: # -xc99=%none Do NOT allow for c99 extensions to be used

RE: disabled c99 in Solaris builds

2018-12-12 Thread Baesken, Matthias
1. Dezember 2018 23:16 > To: Erik Joelsson ; Baesken, Matthias > ; 'build-dev@openjdk.java.net' d...@openjdk.java.net> > Subject: Re: disabled c99 in Solaris builds > > On 12/12/2018 3:27 am, Erik Joelsson wrote: > > Hello, > > > > I do not know why this flag wa

Re: disabled c99 in Solaris builds

2018-12-11 Thread David Holmes
On 12/12/2018 3:27 am, Erik Joelsson wrote: Hello, I do not know why this flag was introduced, but it has been there for a long time. In JDK7 it's listed in jdk/make/common/Defs-solaris.gmk: #   -xc99=%none Do NOT allow for c99 extensions to be used. #   e.g.

Re: disabled c99 in Solaris builds

2018-12-11 Thread Kim Barrett
> On Dec 11, 2018, at 12:27 PM, Erik Joelsson wrote: > > Hello, > > I do not know why this flag was introduced, but it has been there for a long > time. In JDK7 it's listed in jdk/make/common/Defs-solaris.gmk: > > # -xc99=%none Do NOT allow for c99 extensions to be used. > #

Re: disabled c99 in Solaris builds

2018-12-11 Thread Erik Joelsson
Hello, I do not know why this flag was introduced, but it has been there for a long time. In JDK7 it's listed in jdk/make/common/Defs-solaris.gmk: #   -xc99=%none Do NOT allow for c99 extensions to be used. #   e.g. declarations must precede statements and was