Re: [OpenJDK 2D-Dev] RFR: 8008022: Upgrade Direct X SDK used to build JDK

2013-09-09 Thread Vadim Pakhnushev
Phil, I've tested it on the clean Windows 7 virtual machine with only VS2010 installed as well on a number of configurations with and without DXSDK (even on my VS2012 only setup). Thanks, Vadim On 09.09.2013 19:49, Phil Race wrote: Seems fine to me given that the versions are identical acros

Re: [OpenJDK 2D-Dev] RFR: 8008022: Upgrade Direct X SDK used to build JDK

2013-09-09 Thread Phil Race
Seems fine to me given that the versions are identical across all SDKs we might use. Also since this simply removes a required build component, there should be no 'flag day' where people need to be given notice to install a new build component. I think you said that you didn't have the standalon

Re: RFR: 8008022: Upgrade Direct X SDK used to build JDK

2013-09-09 Thread Magnus Ihse Bursie
On 2013-09-06 22:21, Vadim Pakhnushev wrote: Hi all, Please review the fix for this bug: http://bugs.sun.com/view_bug.do?bug_id=8008022 http://cr.openjdk.java.net/~vadim/8008022/webrev.00/ The new build part of the change looks good. (I have not looked at the old build files.) Always nice

Re: RFR: 8008022: Upgrade Direct X SDK used to build JDK

2013-09-08 Thread Ivan Krylov
I can't be a reviewer for this change but I do want to support it. I'd be happy to see this rudimentary dependency go away. Ideally I would like to see later a back port to JDK7. Ivan On Sep 7, 2013, at 12:21 AM, Vadim Pakhnushev wrote: > Hi all, > > Please review the fix for this bug: > ht

RFR: 8008022: Upgrade Direct X SDK used to build JDK

2013-09-06 Thread Vadim Pakhnushev
Hi all, Please review the fix for this bug: http://bugs.sun.com/view_bug.do?bug_id=8008022 http://cr.openjdk.java.net/~vadim/8008022/webrev.00/ I've found that all needed DirectX 9 SDK files (that is, d3d9.h, dsound.h and dsound.lib) are included in the Windows SDK 7.0a shipped with Visual St