Re: RFR: 8135083 Product version string for DLLs and EXEs should not include trailing zeros

2015-09-10 Thread Magnus Ihse Bursie
On 2015-09-09 23:12, Daniil Titov wrote: This review request is a part of the work for JEP-223 that adjusts the changes in RC_FLAGS implemented in the initial patch "JDK-8085822 JEP 223: New Version-String Scheme (initial integration)" to ensure that the product version string for Windows DLL/

Re: RFR: 8135083 Product version string for DLLs and EXEs should not include trailing zeros

2015-09-09 Thread David Katleman
Change looks correct Daniil and I don't see any other instances where VERSION_NUMBER_FOUR_POSITIONS is incorrectly used. Approved. Dave On 9/9/2015 2:12 PM, Daniil Titov wrote: This review request is a part of the work for JEP-223 that adjusts the changes in RC_FLAGS implemented in t

RE: RFR: 8135083 Product version string for DLLs and EXEs should not include trailing zeros

2015-09-09 Thread Iris Clark
version string for DLLs and EXEs should not include trailing zeros This review request is a part of the work for JEP-223 that adjusts the changes in RC_FLAGS implemented in the initial patch "JDK-8085822 JEP 223: New Version-String Scheme (initial integration)" to ensure that the produ

RFR: 8135083 Product version string for DLLs and EXEs should not include trailing zeros

2015-09-09 Thread Daniil Titov
This review request is a part of the work for JEP-223 that adjusts the changes in RC_FLAGS implemented in the initial patch "JDK-8085822 JEP 223: New Version-String Scheme (initial integration)" to ensure that the product version string for Windows DLL/EXEs consists of dot-separated digits WITHO