Re: RFR: 8156756: Enable build-time use of resource ordering plugin

2016-05-12 Thread Mandy Chung
> On May 12, 2016, at 1:37 AM, Erik Joelsson wrote: > > Assuming you meant [1] and that you actually tried it, this looks fine, > thanks! > > /Erik > > [1] http://cr.openjdk.java.net/~redestad/8156756/webrev.02/ > Looks fine. Nit: 117 JLINK_ORDER_RESOURCES := \ 118 *module-info.clas

Re: RFR: 8156756: Enable build-time use of resource ordering plugin

2016-05-12 Thread Claes Redestad
On 2016-05-12 10:38, Alan Bateman wrote: On 12/05/2016 09:37, Erik Joelsson wrote: Assuming you meant [1] Correct, sorry about that. and that you actually tried it, this looks fine, thanks! Built and verified the jimage layout locally, but also doing a sanity build on all plattforms be

Re: RFR: 8156756: Enable build-time use of resource ordering plugin

2016-05-12 Thread Alan Bateman
On 12/05/2016 09:37, Erik Joelsson wrote: Assuming you meant [1] and that you actually tried it, this looks fine, thanks! /Erik [1] http://cr.openjdk.java.net/~redestad/8156756/webrev.02/ I'm happy too. -Alan.

Re: RFR: 8156756: Enable build-time use of resource ordering plugin

2016-05-12 Thread Erik Joelsson
Assuming you meant [1] and that you actually tried it, this looks fine, thanks! /Erik [1] http://cr.openjdk.java.net/~redestad/8156756/webrev.02/ On 2016-05-12 02:01, Claes Redestad wrote: On 2016-05-11 18:25, Erik Joelsson wrote: Alan is correct , I have issues with the long line. :) I rec

Re: RFR: 8156756: Enable build-time use of resource ordering plugin

2016-05-11 Thread Claes Redestad
On 2016-05-11 18:25, Erik Joelsson wrote: Alan is correct , I have issues with the long line. :) I recommend something like this: JLINK_ORDER_RESOURCES := \ *module-info.class* \ @$(SUPPORT_OUTPUTDIR)/classlist/classlist,/java.base/java/* \ /java.base/jdk/* \ /java.base/sun/* \

Re: RFR: 8156756: Enable build-time use of resource ordering plugin

2016-05-11 Thread Erik Joelsson
Alan is correct , I have issues with the long line. :) I recommend something like this: JLINK_ORDER_RESOURCES := \ *module-info.class* \ @$(SUPPORT_OUTPUTDIR)/classlist/classlist,/java.base/java/* \ /java.base/jdk/* \ /java.base/sun/* \ /java.base/com/* \ /jdk.localedata/

Re: RFR: 8156756: Enable build-time use of resource ordering plugin

2016-05-11 Thread Alan Bateman
On 11/05/2016 16:56, Claes Redestad wrote: Hi, please review this change to enable the --order-resources plugin during build, which helps cold start scenarios by improving locality Bug: https://bugs.openjdk.java.net/browse/JDK-8156756 Webrev: http://cr.openjdk.java.net/~redestad/8156756/webre

Re: RFR: 8156756: Enable build-time use of resource ordering plugin

2016-05-11 Thread Jim Laskey (Oracle)
+1 > On May 11, 2016, at 12:56 PM, Claes Redestad > wrote: > > Hi, > > please review this change to enable the --order-resources plugin during > build, which helps cold start scenarios by improving locality > > Bug: https://bugs.openjdk.java.net/browse/JDK-8156756 > Webrev: http://cr.openjdk

RFR: 8156756: Enable build-time use of resource ordering plugin

2016-05-11 Thread Claes Redestad
Hi, please review this change to enable the --order-resources plugin during build, which helps cold start scenarios by improving locality Bug: https://bugs.openjdk.java.net/browse/JDK-8156756 Webrev: http://cr.openjdk.java.net/~redestad/8156756/webrev.01/ Ordering by classlist alone gives a g