Re: RFR: 8165440: Add zero support for x86_64-linux-gnux32 target

2018-09-05 Thread John Paul Adrian Glaubitz
You’re right, sorry. I haven’t been around OpenJDK for some weeks and forgot about posting to build-dev when posting. I will push in around 2-3 hours, currently on a train. Adrian > On Sep 5, 2018, at 9:05 AM, Magnus Ihse Bursie > wrote: > >> On 2018-09-04 23:29, David Holmes wrote: >> Hi Ad

Re: RFR: 8165440: Add zero support for x86_64-linux-gnux32 target

2018-09-05 Thread Magnus Ihse Bursie
On 2018-09-04 23:29, David Holmes wrote: Hi Adrian, All changes that touch the build system must be reviewed by build-dev - now cc'd. This has been discussed at some length in build-dev. But I agree, it's good that also the actual RFR is cc:ed here. The patch, unsurprisingly, LGTM. /Magnus

Re: RFR: 8165440: Add zero support for x86_64-linux-gnux32 target

2018-09-04 Thread Erik Joelsson
Looks ok to me. /Erik On 2018-09-04 14:29, David Holmes wrote: Hi Adrian, All changes that touch the build system must be reviewed by build-dev - now cc'd. These changes seem reasonable, though I don't like adding changes in source code for such an obscure (and unsupported!) platform. D

Re: RFR: 8165440: Add zero support for x86_64-linux-gnux32 target

2018-09-04 Thread David Holmes
Hi Adrian, All changes that touch the build system must be reviewed by build-dev - now cc'd. These changes seem reasonable, though I don't like adding changes in source code for such an obscure (and unsupported!) platform. David On 5/09/2018 3:45 AM, John Paul Adrian Glaubitz wrote: Hi!