Re: RFR: 8200729: Conditional compilation of GCs

2018-05-03 Thread Stefan Karlsson
Hi Vladimir, On 2018-05-03 18:56, Vladimir Kozlov wrote: I see that you don't guard Use*GC flags with _ONLY macros. It is hard to figure out from gcConfig.cpp what happened if UseG1GC is specified on command line for VM which does not include it. What happens? Right. The current patch leaves

Re: RFR: 8200729: Conditional compilation of GCs

2018-05-03 Thread Vladimir Kozlov
I see that you don't guard Use*GC flags with _ONLY macros. It is hard to figure out from gcConfig.cpp what happened if UseG1GC is specified on command line for VM which does not include it. What happens? I don't see C1 changes but it looks like it was changed with 8201543. C2 changes seems fine

Re: RFR: 8200729: Conditional compilation of GCs

2018-05-03 Thread Stefan Karlsson
On 2018-05-03 15:19, Erik Helin wrote: On 05/02/2018 04:37 PM, Stefan Karlsson wrote: > Hi all, Hi Stefan, thanks for taking on this work, much appreciated! On 05/02/2018 04:37 PM, Stefan Karlsson wrote: > The first patch simply cleans up some INCLUDE_ALL_GCS usages in platform-specific fil

Re: RFR: 8200729: Conditional compilation of GCs

2018-05-03 Thread Erik Helin
On 05/02/2018 04:37 PM, Stefan Karlsson wrote: > Hi all, Hi Stefan, thanks for taking on this work, much appreciated! On 05/02/2018 04:37 PM, Stefan Karlsson wrote: > The first patch simply cleans up some INCLUDE_ALL_GCS usages in platform-specific files. Some of these changes are already bein

Re: RFR: 8200729: Conditional compilation of GCs

2018-05-03 Thread Stefan Karlsson
On 2018-05-03 11:06, Magnus Ihse Bursie wrote: On 2018-05-02 16:37, Stefan Karlsson wrote: Hi all, Please review these patches to allow for conditional compilation of the GCs in HotSpot. Full patch: http://cr.openjdk.java.net/~stefank/8200729/webrev.04/all/ It's nice to see this cleanup i

Re: RFR: 8200729: Conditional compilation of GCs

2018-05-03 Thread Magnus Ihse Bursie
On 2018-05-02 16:37, Stefan Karlsson wrote: Hi all, Please review these patches to allow for conditional compilation of the GCs in HotSpot. Full patch: http://cr.openjdk.java.net/~stefank/8200729/webrev.04/all/ It's nice to see this cleanup in build logic! I spotted one issue with the bui

RFR: 8200729: Conditional compilation of GCs

2018-05-02 Thread Stefan Karlsson
Hi all, Please review these patches to allow for conditional compilation of the GCs in HotSpot. Full patch: http://cr.openjdk.java.net/~stefank/8200729/webrev.04/all/ (See below for a more fine-grained division into smaller patches) Today Parallel, G1, and CMS, are all guarded by INCLUDE_AL