Looks ok to me.
/Erik
On 2018-09-17 06:48, Severin Gehwolf wrote:
Hi,
Please review this 8u backport of JDK-8207057 which adds debug info
when assembling assembler files. The build system changed between 9+
and 8u, so it's an independent patch from JDK 12's version.
Bug: https://bugs.openjdk
Hi,
Please review this 8u backport of JDK-8207057 which adds debug info
when assembling assembler files. The build system changed between 9+
and 8u, so it's an independent patch from JDK 12's version.
Bug: https://bugs.openjdk.java.net/browse/JDK-8207057
webrev: http://cr.openjdk.java.net/~sgehwo
This looks good to me given that the jdk-submit passes.
We are in RDP 1 for JDK 11 and this bug is currently classified as a P4
while the threshold now is P3. While I agree that the risk is low, you
need to make a case for why it's a P3 to get into 11.
/Erik
On 2018-07-13 07:54, Severin Geh
On Fri, 2018-07-13 at 06:57 -0700, Erik Joelsson wrote:
> This looks good. I checked on my mac and it seems you can safely add -g
> for clang as well. For Solaris I can't find any reasonable flag, so ok
> to leave it. For windows it's not relevant at this point since we don't
> have any assembly
This looks good. I checked on my mac and it seems you can safely add -g
for clang as well. For Solaris I can't find any reasonable flag, so ok
to leave it. For windows it's not relevant at this point since we don't
have any assembly AFAIK.
/Erik
On 2018-07-13 01:46, Severin Gehwolf wrote:
O
On Fri, 2018-07-13 at 10:46 +0200, Severin Gehwolf wrote:
> New webrev:
> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8207057/webrev.02/
>
> This leaves non-GCC toolchains unchanged since I don't know the
> relevant flags (if they even exist). I'd be happy to add them if
> somebody tells me w
On Fri, 2018-07-13 at 09:29 +0200, Severin Gehwolf wrote:
> Hi Erik,
>
> Thanks for the review!
>
> On Thu, 2018-07-12 at 09:47 -0700, Erik Joelsson wrote:
> > Hello Severin,
> > From looking at your jdk-submit job I can already say that it's not working
> > on Solaris:
> > jib > /bin/as: error:
Hi Erik,
Thanks for the review!
On Thu, 2018-07-12 at 09:47 -0700, Erik Joelsson wrote:
> Hello Severin,
> From looking at your jdk-submit job I can already say that it's not working
> on Solaris:
> jib > /bin/as: error: unknown option 'g0'
> jib > /bin/as: error: unknown option 'xs'
> jib > usa
Hello Severin,
From looking at your jdk-submit job I can already say that it's not
working on Solaris:
jib > /bin/as: error: unknown option 'g0'
jib > /bin/as: error: unknown option 'xs'
jib > usage: /bin/as [-V] [-Q{y,n}] [-s]
jib >[-S{a|b|c|l|A|B|C|L}] [-hwcap={1|0}] [-o objfile] [-L
Hi,
Could I please get a review of this build fix? The problem is that no
debug info gets ever generated for assembler files in hotspot. The
proposed fix is to generated debug info via CFLAGS_DEBUG_SYMBOLS if so
requested. For example --with-native-debug-info=none no debug info is
generated. --wit
10 matches
Mail list logo
