Re: RFR: 8208484: color contrast issues in javadoc

2018-07-31 Thread Magnus Ihse Bursie
Looks good to me. The original css file was created by me, yes, but not much design work went into it. I think I just used a stripped-down version of formatting i found in some older html files, and converted it to a css file. /Magnus > 30 juli 2018 kl. 12:53 skrev Jonathan Gibbons : > > Th

Re: RFR: 8208484: color contrast issues in javadoc

2018-07-30 Thread Jonathan Gibbons
The other/referenced bug only changed one of the colors that is changed in this webrev, 119 tr:nth-child(even), tr:nth-child(even) th[scope=row] { 120 background: #E3E3E3; 121 } But I note the other change is inline with the content of the standard javadoc style file: jdk-default.css 77

Re: RFR: 8208484: color contrast issues in javadoc

2018-07-30 Thread Priya Lakshmi Muthuswamy
Hi, Screenshots with changes attached to the bug. Thanks, Priya On 7/30/2018 2:40 PM, Priya Lakshmi Muthuswamy wrote: Hi, Kindly review fix for https://bugs.openjdk.java.net/browse/JDK-8208484 webrev : http://cr.openjdk.java.net/~pmuthuswamy/8208484/webrev.00/ Have set a slightly lighter sha

RFR: 8208484: color contrast issues in javadoc

2018-07-30 Thread Priya Lakshmi Muthuswamy
Hi, Kindly review fix for https://bugs.openjdk.java.net/browse/JDK-8208484 webrev : http://cr.openjdk.java.net/~pmuthuswamy/8208484/webrev.00/ Have set a slightly lighter shade to background and darker shade for foreground. This change is similar to https://bugs.openjdk.java.net/browse/JDK-819