On 2019-02-18 12:02, Severin Gehwolf wrote:
Hi Magnus,
On Mon, 2019-02-18 at 09:32 +0100, Magnus Ihse Bursie wrote:
15 feb. 2019 kl. 18:01 skrev Severin Gehwolf :
Hi Alan, Mandy,
Here is the next round of this change:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8214796/06/webrev/
Loo
Hi Magnus,
On Mon, 2019-02-18 at 09:32 +0100, Magnus Ihse Bursie wrote:
> > 15 feb. 2019 kl. 18:01 skrev Severin Gehwolf :
> >
> > Hi Alan, Mandy,
> >
> > Here is the next round of this change:
> > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8214796/06/webrev/
>
> Looks good from the build
> 15 feb. 2019 kl. 18:01 skrev Severin Gehwolf :
>
> Hi Alan, Mandy,
>
> Here is the next round of this change:
> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8214796/06/webrev/
Looks good from the build PoV, with one minor nit: In JtregNativeJdk.gmk,
please use the new construct:
ifeq (
Hi Alan, Mandy,
Here is the next round of this change:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8214796/06/webrev/
It now also has tests which don't require objcopy to be present on test
machines as well as being integrated with --strip-debug (once JDK-
8218913 is pushed). --list-plugins
On Wed, 2019-02-13 at 15:36 -0800, Mandy Chung wrote:
> On 2/13/19 1:04 AM, Severin Gehwolf wrote:
> > > --strip-native-debug-symbols no-keep-debuginfo
> > --strip-native-debug-symbols strip-debuginfo
> > --strip-native-debug-symbols remove-debuginfo
> >
> > It would avoid using negation.
>
On 2/13/19 1:04 AM, Severin Gehwolf wrote:
--strip-native-debug-symbols no-keep-debuginfo
--strip-native-debug-symbols strip-debuginfo
--strip-native-debug-symbols remove-debuginfo
It would avoid using negation.
What about 'omit', i.e.
--strip-native-debug-symbols omit-debuginfo
--st
On Tue, 2019-02-12 at 15:29 -0800, Mandy Chung wrote:
>
> On 2/12/19 11:52 AM, Severin Gehwolf wrote:
> > Hi Mandy, Alan,
> >
> > Please find the proposal for CLI option of --strip-native-debug-symbols
> > below.
> >
> > The current implementation here has the following options:
> > http://cr.op
On 2/12/19 11:52 AM, Severin Gehwolf wrote:
Hi Mandy, Alan,
Please find the proposal for CLI option of --strip-native-debug-symbols
below.
The current implementation here has the following options:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8214796/05/webrev/
[i] --strip-native-debu
On 2/12/19 12:05 PM, Severin Gehwolf wrote:
Hi Mandy,
Thanks for the review!
OK. Here is the summary:
http://mail.openjdk.java.net/pipermail/jigsaw-dev/2019-February/014132.html
Personally, I find --strip-native-debug-info or --strip-native-debug-
symbols clearer than just --strip-native-de
Hi Mandy,
Thanks for the review!
On Thu, 2019-02-07 at 12:43 -0800, Mandy Chung wrote:
> Hi Severin,
>
> Using the plugin specific ResourceBundle is good. Thanks for making
> the change.
>
> I see that Alan's comment [1] on the plugin options and I assume
> you will investigate the plugin opti
Hi Mandy, Alan,
Please find the proposal for CLI option of --strip-native-debug-symbols
below.
On Fri, 2019-02-08 at 10:53 -0800, Mandy Chung wrote:
>
> On 2/8/19 2:08 AM, Alan Bateman wrote:
> > I agree with Mandy that the CLI options need examination. The proposed
> > `--strip-native-debug-s
Hello,
On 2019-02-12 09:05, Severin Gehwolf wrote:
Hi Erik,
On Tue, 2019-02-12 at 08:44 -0800, Erik Joelsson wrote:
On 2019-02-12 01:35, Severin Gehwolf wrote:
Hi Erik,
On Mon, 2019-02-11 at 11:12 -0800, Erik Joelsson wrote:
Hello Severin,
I think you also need a $(wildcard ) around it, bu
Hi Erik,
On Tue, 2019-02-12 at 08:44 -0800, Erik Joelsson wrote:
> On 2019-02-12 01:35, Severin Gehwolf wrote:
> > Hi Erik,
> >
> > On Mon, 2019-02-11 at 11:12 -0800, Erik Joelsson wrote:
> > > Hello Severin,
> > >
> > > I think you also need a $(wildcard ) around it, but I may be wrong. Did
> >
On 2019-02-12 01:35, Severin Gehwolf wrote:
Hi Erik,
On Mon, 2019-02-11 at 11:12 -0800, Erik Joelsson wrote:
Hello Severin,
I think you also need a $(wildcard ) around it, but I may be wrong. Did
you try this version?
Yes, this version works for me without $(wildcard). Why is it needed?
I
Hi Erik,
On Mon, 2019-02-11 at 11:12 -0800, Erik Joelsson wrote:
> Hello Severin,
>
> I think you also need a $(wildcard ) around it, but I may be wrong. Did
> you try this version?
Yes, this version works for me without $(wildcard). Why is it needed?
> Also, please do not indent so much. We h
Hello Severin,
I think you also need a $(wildcard ) around it, but I may be wrong. Did
you try this version?
Also, please do not indent so much. We have style guidelines [1], which
recommend 4 spaces for line break indentation.
/Erik
[1] http://openjdk.java.net/groups/build/doc/code-conven
Hi Alan,
Thanks for the review!
On Fri, 2019-02-08 at 10:08 +, Alan Bateman wrote:
> On 07/02/2019 17:09, Severin Gehwolf wrote:
> > Hi,
> >
> > Could I please get reviews for this enhancement? It adds a debug
> > symbols stripping plug-in to jlink for Linux and Unix platforms. It's
> > the
Hi Erik,
On Thu, 2019-02-07 at 17:01 -0800, Erik Joelsson wrote:
> On 2019-02-07 11:09, Severin Gehwolf wrote:
> > Hi Erik,
> >
> > On Thu, 2019-02-07 at 09:39 -0800, Erik Joelsson wrote:
> > > Hello Severin,
> > >
> > > There is a macro for automatically finding all source dirs for a module.
>
On 08/02/2019 18:53, Mandy Chung wrote:
Renaming it to make it clear is good. How about:
--strip-debug-attribute
--strip-native-debug-symbols
--strip-debug will invoke both --strip-debug-attribute and
--strip-native-debug-symbols, if supported.
Typically we want to strip both. If only strip
On 2/8/19 2:08 AM, Alan Bateman wrote:
I agree with Mandy that the CLI options need examination. The proposed
`--strip-native-debug-symbols` seems reasonable but it will be
inconsistent with the existing `--strip-debug` option. Mandy - what you
would think about renaming the existing option
On 07/02/2019 17:09, Severin Gehwolf wrote:
Hi,
Could I please get reviews for this enhancement? It adds a debug
symbols stripping plug-in to jlink for Linux and Unix platforms. It's
the first platform specific jlink plugin and the approach taken for
keeping it contained is to use a plugin speci
On 2019-02-07 11:09, Severin Gehwolf wrote:
Hi Erik,
On Thu, 2019-02-07 at 09:39 -0800, Erik Joelsson wrote:
Hello Severin,
There is a macro for automatically finding all source dirs for a module.
So in Gensrc-jdk.jlink.gmk, I think it would be better expressed using
that macro, like this:
Hi Severin,
Using the plugin specific ResourceBundle is good. Thanks for making
the change.
I see that Alan's comment [1] on the plugin options and I assume
you will investigate the plugin options and bring back a proposal.
Did I miss the discussion on these options?
Option:
--strip-native-de
Hi Erik,
On Thu, 2019-02-07 at 09:39 -0800, Erik Joelsson wrote:
> Hello Severin,
>
> There is a macro for automatically finding all source dirs for a module.
> So in Gensrc-jdk.jlink.gmk, I think it would be better expressed using
> that macro, like this:
>
> JLINK_RESOURCE_DIRS := $(wildcard
Hello Severin,
There is a macro for automatically finding all source dirs for a module.
So in Gensrc-jdk.jlink.gmk, I think it would be better expressed using
that macro, like this:
JLINK_RESOURCE_DIRS := $(wildcard $(addsuffix
/jdk/tools/jlink/resources, $(call FindModuleSrcSdirs, jdk.jlink
Hi,
Could I please get reviews for this enhancement? It adds a debug
symbols stripping plug-in to jlink for Linux and Unix platforms. It's
the first platform specific jlink plugin and the approach taken for
keeping it contained is to use a plugin specific ResourceBundle.
Discussion for this happen
26 matches
Mail list logo
