Re: RFR: 8223347: Integration of Vector API (Incubator) [v6]

2020-10-14 Thread Paul Sandoz
> This pull request is for integration of the Vector API. It was previously > reviewed under conditions when mercurial was > used for the source code control system. Review threads can be found here > (searching for issue number 8223347 in the > title): >

Re: RFR: 8223347: Integration of Vector API (Incubator) [v5]

2020-10-14 Thread Paul Sandoz
> This pull request is for integration of the Vector API. It was previously > reviewed under conditions when mercurial was > used for the source code control system. Review threads can be found here > (searching for issue number 8223347 in the > title): >

Re: RFR: 8223347: Integration of Vector API (Incubator) [v4]

2020-10-13 Thread Ekaterina Pavlova
On Wed, 14 Oct 2020 00:34:04 GMT, Sandhya Viswanathan wrote: >> There are several gc tests crashed in panama-vector tier3 testing which >> seems are not observed in openjdk repo. >> The crashes look like: >> # assert(oopDesc::is_oop(obj)) failed: not an oop: 0xfff1 >> # >> # JRE

Re: RFR: 8223347: Integration of Vector API (Incubator) [v4]

2020-10-13 Thread Sandhya Viswanathan
On Tue, 13 Oct 2020 21:29:52 GMT, Ekaterina Pavlova wrote: >> Build changes look good. > > There are several gc tests crashed in panama-vector tier3 testing which seems > are not observed in openjdk repo. > The crashes look like: > # assert(oopDesc::is_oop(obj)) failed: not an oop:

Re: RFR: 8223347: Integration of Vector API (Incubator) [v4]

2020-10-13 Thread Ekaterina Pavlova
On Mon, 12 Oct 2020 12:56:10 GMT, Erik Joelsson wrote: >> Paul Sandoz has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now >> contains ten commits: >> - Merge master >> - Fix related to merge >> - HotspotIntrinsicCandidate to

Re: RFR: 8223347: Integration of Vector API (Incubator) [v4]

2020-10-13 Thread Paul Sandoz
> This pull request is for integration of the Vector API. It was previously > reviewed under conditions when mercurial was > used for the source code control system. Review threads can be found here > (searching for issue number 8223347 in the > title): >

Re: RFR: 8223347: Integration of Vector API (Incubator) [v3]

2020-10-13 Thread Paul Sandoz
> This pull request is for integration of the Vector API. It was previously > reviewed under conditions when mercurial was > used for the source code control system. Review threads can be found here > (searching for issue number 8223347 in the > title): >

Re: RFR: 8223347: Integration of Vector API (Incubator) [v2]

2020-10-12 Thread Paul Sandoz
> This pull request is for integration of the Vector API. It was previously > reviewed under conditions when mercurial was > used for the source code control system. Review threads can be found here > (searching for issue number 8223347 in the > title): >

Re: RFR: 8223347: Integration of Vector API (Incubator)

2020-10-12 Thread Erik Joelsson
On Fri, 25 Sep 2020 20:14:29 GMT, Paul Sandoz wrote: > This pull request is for integration of the Vector API. It was previously > reviewed under conditions when mercurial was > used for the source code control system. Review threads can be found here > (searching for issue number 8223347 in

Re: RFR: 8223347: Integration of Vector API (Incubator)

2020-10-11 Thread Joe Darcy
On Fri, 25 Sep 2020 20:14:29 GMT, Paul Sandoz wrote: > This pull request is for integration of the Vector API. It was previously > reviewed under conditions when mercurial was > used for the source code control system. Review threads can be found here > (searching for issue number 8223347 in

Re: RFR: 8223347: Integration of Vector API (Incubator)

2020-10-02 Thread Chris Hegarty
On Fri, 25 Sep 2020 20:14:29 GMT, Paul Sandoz wrote: > This pull request is for integration of the Vector API. It was previously > reviewed under conditions when mercurial was > used for the source code control system. Review threads can be found here > (searching for issue number 8223347 in

Re: RFR: 8223347: Integration of Vector API (Incubator)

2020-10-02 Thread Vladimir Kozlov
On Fri, 25 Sep 2020 20:14:29 GMT, Paul Sandoz wrote: > This pull request is for integration of the Vector API. It was previously > reviewed under conditions when mercurial was > used for the source code control system. Review threads can be found here > (searching for issue number 8223347 in

Re: RFR: 8223347: Integration of Vector API (Incubator)

2020-09-30 Thread Jie Fu
On Thu, 1 Oct 2020 01:01:23 GMT, Paul Sandoz wrote: >> Hi @PaulSandoz , >> >> I think it would be better to integrate it [1] in this MR. >> >> I have tested this MR on our AVX512 machines and it still crashes. >> Also, for the sake of maintenance, it seems NOT a good idea to push a >>

Re: RFR: 8223347: Integration of Vector API (Incubator)

2020-09-30 Thread Paul Sandoz
On Thu, 1 Oct 2020 00:25:46 GMT, Jie Fu wrote: >> @DamonFool we can follow up later for that fix (and others in >> `vectorIntrinsics`), after this PR integrates. I don't >> want to perturb the code that has already been reviewed, which requires yet >> more additional review. > > Hi @PaulSandoz

Re: RFR: 8223347: Integration of Vector API (Incubator)

2020-09-30 Thread Jie Fu
On Wed, 30 Sep 2020 18:19:53 GMT, Paul Sandoz wrote: >> Hi @PaulSandoz , >> >> This integration seems to miss >> https://github.com/openjdk/panama-vector/pull/1, which had fixed crashes on >> AVX512 >> machines. >> Thanks. > > @DamonFool we can follow up later for that fix (and others in >

Re: RFR: 8223347: Integration of Vector API (Incubator)

2020-09-29 Thread Jie Fu
On Tue, 29 Sep 2020 22:00:04 GMT, Erik Joelsson wrote: >> This pull request is for integration of the Vector API. It was previously >> reviewed under conditions when mercurial was >> used for the source code control system. Review threads can be found here >> (searching for issue number

Re: RFR: 8223347: Integration of Vector API (Incubator)

2020-09-29 Thread Erik Joelsson
On Fri, 25 Sep 2020 20:14:29 GMT, Paul Sandoz wrote: > This pull request is for integration of the Vector API. It was previously > reviewed under conditions when mercurial was > used for the source code control system. Review threads can be found here > (searching for issue number 8223347 in

RFR: 8223347: Integration of Vector API (Incubator)

2020-09-29 Thread Paul Sandoz
This pull request is for integration of the Vector API. It was previously reviewed under conditions when mercurial was used for the source code control system. Review threads can be found here (searching for issue number 8223347 in the title):