Re: RFR: 8240259: Disable -Wshift-negative-value warnings

2020-05-22 Thread Kim Barrett
> On May 22, 2020, at 3:38 AM, Magnus Ihse Bursie > wrote: > > Looks good to me. Thanks. > > /Magnus > > On 2020-05-22 03:54, Kim Barrett wrote: >> Please review this change which disables warnings for left shift of a >> negative value when compiling HotSpot with gcc or clang. This warning

Re: RFR: 8240259: Disable -Wshift-negative-value warnings

2020-05-22 Thread Magnus Ihse Bursie
Looks good to me. /Magnus On 2020-05-22 03:54, Kim Barrett wrote: Please review this change which disables warnings for left shift of a negative value when compiling HotSpot with gcc or clang. This warning isn't helpful, given that all compilers seem to do the obvious thing, and that obvious t

RFR: 8240259: Disable -Wshift-negative-value warnings

2020-05-21 Thread Kim Barrett
Please review this change which disables warnings for left shift of a negative value when compiling HotSpot with gcc or clang. This warning isn't helpful, given that all compilers seem to do the obvious thing, and that obvious thing will soon-ish (C++20) be the specified thing. See the CR for more