On 4/22/20 6:00 PM, Severin Gehwolf wrote:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8243059
> webrev:
> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8243059/jdk11/01/webrev/
> original change: https://hg.openjdk.java.net/jdk/jdk/rev/dff3aabdc2f3
>
> Testing: Build fails before, passes
Hi,
Could I please get a review of this 11u backport of a build fix? The
jdk/jdk patch does not apply cleanly since JDK-8222510[1] isn't in
OpenJDK 11u. I.e. this makes the context different and the patch
failing to apply. I've manually ported the patch. The gist is:
$(VERSION_CFLAGS) => $$(VERSI
On Fri, 2020-04-17 at 07:32 -0700, Erik Joelsson wrote:
> This version looks good to me.
Thanks for the review, Erik!
Cheers,
Severin
> /Erik
>
> On 2020-04-17 05:15, Severin Gehwolf wrote:
> > Hi Magnus,
> >
> > On Fri, 2020-04-17 at 13:44 +0200, Magnus Ihse Bursie wrote:
> > > On 2020-04-17
This version looks good to me.
/Erik
On 2020-04-17 05:15, Severin Gehwolf wrote:
Hi Magnus,
On Fri, 2020-04-17 at 13:44 +0200, Magnus Ihse Bursie wrote:
On 2020-04-17 12:18, Severin Gehwolf wrote:
Hi,
Could I please get a review of this build fix? When --with-vendor-name
contains a comma, l
On Fri, 2020-04-17 at 14:28 +0200, Magnus Ihse Bursie wrote:
> On 2020-04-17 14:15, Severin Gehwolf wrote:
> > Hi Magnus,
> >
> > On Fri, 2020-04-17 at 13:44 +0200, Magnus Ihse Bursie wrote:
> > > On 2020-04-17 12:18, Severin Gehwolf wrote:
> > > > Hi,
> > > >
> > > > Could I please get a review
On 2020-04-17 14:15, Severin Gehwolf wrote:
Hi Magnus,
On Fri, 2020-04-17 at 13:44 +0200, Magnus Ihse Bursie wrote:
On 2020-04-17 12:18, Severin Gehwolf wrote:
Hi,
Could I please get a review of this build fix? When --with-vendor-name
contains a comma, like 'foo, bar, Inc.' the build fails. A
Hi Magnus,
On Fri, 2020-04-17 at 13:44 +0200, Magnus Ihse Bursie wrote:
> On 2020-04-17 12:18, Severin Gehwolf wrote:
> > Hi,
> >
> > Could I please get a review of this build fix? When --with-vendor-name
> > contains a comma, like 'foo, bar, Inc.' the build fails. As it turns
> > out SetupBuildL
On 2020-04-17 12:18, Severin Gehwolf wrote:
Hi,
Could I please get a review of this build fix? When --with-vendor-name
contains a comma, like 'foo, bar, Inc.' the build fails. As it turns
out SetupBuildLauncherBody calls SetupJdkExecutable with some
parameters. If $(VERSION_CFLAGS) contain a com
Hi,
Could I please get a review of this build fix? When --with-vendor-name
contains a comma, like 'foo, bar, Inc.' the build fails. As it turns
out SetupBuildLauncherBody calls SetupJdkExecutable with some
parameters. If $(VERSION_CFLAGS) contain a comma, the comma is being
treated as a prameter d
