Re: RFR: 8253424: Add support for running pre-submit testing using GitHub Actions

2020-09-28 Thread Magnus Ihse Bursie
On 2020-09-23 19:27, Erik Joelsson wrote: The version-numbers file (which is also a shared properties style file) is not using quotes for values, which is fine as long as there are no spaces. I believe if you read it as a properties file, you need to strip the quotes if you have them. I prefe

Re: RFR: 8253424: Add support for running pre-submit testing using GitHub Actions [v7]

2020-09-27 Thread Robin Westberg
> A few days ago I posted an initial version of the necessary configuration > required to run pre-submit build and tests > for JDK main-line contributions using GitHub Actions [2] and the free tier > [3] available to everyone working with open > source repositories. I've incorporated the feedback

Re: RFR: 8253424: Add support for running pre-submit testing using GitHub Actions [v6]

2020-09-26 Thread Robin Westberg
> A few days ago I posted an initial version of the necessary configuration > required to run pre-submit build and tests > for JDK main-line contributions using GitHub Actions [2] and the free tier > [3] available to everyone working with open > source repositories. I've incorporated the feedback

Re: RFR: 8253424: Add support for running pre-submit testing using GitHub Actions [v5]

2020-09-25 Thread Erik Joelsson
On Fri, 25 Sep 2020 13:10:01 GMT, Robin Westberg wrote: >> A few days ago I posted an initial version of the necessary configuration >> required to run pre-submit build and tests >> for JDK main-line contributions using GitHub Actions [2] and the free tier >> [3] available to everyone working w

Re: RFR: 8253424: Add support for running pre-submit testing using GitHub Actions [v5]

2020-09-25 Thread Erik Helin
On Fri, 25 Sep 2020 13:10:01 GMT, Robin Westberg wrote: >> A few days ago I posted an initial version of the necessary configuration >> required to run pre-submit build and tests >> for JDK main-line contributions using GitHub Actions [2] and the free tier >> [3] available to everyone working w

Re: RFR: 8253424: Add support for running pre-submit testing using GitHub Actions

2020-09-25 Thread Robin Westberg
On Wed, 23 Sep 2020 17:55:23 GMT, Robin Westberg wrote: >> The version-numbers file (which is also a shared properties style file) is >> not using quotes for values, which is fine >> as long as there are no spaces. I believe if you read it as a properties >> file, you need to strip the quotes i

Re: RFR: 8253424: Add support for running pre-submit testing using GitHub Actions [v5]

2020-09-25 Thread Robin Westberg
> A few days ago I posted an initial version of the necessary configuration > required to run pre-submit build and tests > for JDK main-line contributions using GitHub Actions [2] and the free tier > [3] available to everyone working with open > source repositories. I've incorporated the feedback

Re: RFR: 8253424: Add support for running pre-submit testing using GitHub Actions [v4]

2020-09-24 Thread Robin Westberg
> A few days ago I posted an initial version of the necessary configuration > required to run pre-submit build and tests > for JDK main-line contributions using GitHub Actions [2] and the free tier > [3] available to everyone working with open > source repositories. I've incorporated the feedback

Re: RFR: 8253424: Add support for running pre-submit testing using GitHub Actions

2020-09-23 Thread Robin Westberg
On Wed, 23 Sep 2020 17:24:39 GMT, Erik Joelsson wrote: >> I added `make/conf/test-dependencies` with version numbers specified on the >> format that `jib-profiles.js` would expect. >> Actually using them from that file as well could perhaps be a separate task >> though. :) > > The version-numbe

Re: RFR: 8253424: Add support for running pre-submit testing using GitHub Actions [v3]

2020-09-23 Thread Robin Westberg
> A few days ago I posted an initial version of the necessary configuration > required to run pre-submit build and tests > for JDK main-line contributions using GitHub Actions [2] and the free tier > [3] available to everyone working with open > source repositories. I've incorporated the feedback

Re: RFR: 8253424: Add support for running pre-submit testing using GitHub Actions

2020-09-23 Thread Erik Joelsson
On Wed, 23 Sep 2020 13:46:50 GMT, Robin Westberg wrote: >> The other primary consumer of this is make/conf/jib-profiles.js. The >> make/conf dir would make sense to me. >> >> The challenge here is creating a set of variables that are suitable enough >> for both config files to consume. For >>

Re: RFR: 8253424: Add support for running pre-submit testing using GitHub Actions [v2]

2020-09-23 Thread Robin Westberg
> A few days ago I posted an initial version of the necessary configuration > required to run pre-submit build and tests > for JDK main-line contributions using GitHub Actions [2] and the free tier > [3] available to everyone working with open > source repositories. I've incorporated the feedback

Re: RFR: 8253424: Add support for running pre-submit testing using GitHub Actions

2020-09-23 Thread Robin Westberg
On Tue, 22 Sep 2020 14:05:42 GMT, Erik Joelsson wrote: >> Sure, should not be that hard to parse something similar. The GitHub actions >> will probably need it in JSON format at >> some point, but nothing a little `sed -e '1i {' -e 's/#.*//g' -e 's/"//g' -e >> 's/(.*)=(.*)/"\1": "\2",/g' -e >>

Re: RFR: 8253424: Add support for running pre-submit testing using GitHub Actions

2020-09-22 Thread Erik Joelsson
On Tue, 22 Sep 2020 13:36:58 GMT, Robin Westberg wrote: >> We don't have a good source currently no, but something to keep in mind. >> Ideally we would want to create a common >> source for both jib-profiles.js and the gitactions to read from. I would >> prefer something that can be read both a

Re: RFR: 8253424: Add support for running pre-submit testing using GitHub Actions

2020-09-22 Thread Robin Westberg
On Mon, 21 Sep 2020 17:22:57 GMT, Erik Joelsson wrote: >> Certainly, the prerequisites step can checkout additional repositories and >> run shell commands to extract variables to >> be used for later steps. Do we have any suitable source for these versions? >> We'll also need download links for

Re: RFR: 8253424: Add support for running pre-submit testing using GitHub Actions

2020-09-21 Thread Erik Joelsson
On Mon, 21 Sep 2020 15:30:41 GMT, Robin Westberg wrote: >> Is there any way to derive the version strings for dependencies from a >> different source? Once pushed, this file will >> require updating whenever the bootjdk, jtreg version or gtest version is >> updated. > > Certainly, the prerequis

Re: RFR: 8253424: Add support for running pre-submit testing using GitHub Actions

2020-09-21 Thread Robin Westberg
On Mon, 21 Sep 2020 13:59:06 GMT, Erik Joelsson wrote: >> A few days ago I posted an initial version of the necessary configuration >> required to run pre-submit build and tests >> for JDK main-line contributions using GitHub Actions [2] and the free tier >> [3] available to everyone working wi

Re: RFR: 8253424: Add support for running pre-submit testing using GitHub Actions

2020-09-21 Thread Erik Joelsson
On Mon, 21 Sep 2020 13:32:09 GMT, Robin Westberg wrote: > A few days ago I posted an initial version of the necessary configuration > required to run pre-submit build and tests > for JDK main-line contributions using GitHub Actions [2] and the free tier > [3] available to everyone working with

RFR: 8253424: Add support for running pre-submit testing using GitHub Actions

2020-09-21 Thread Robin Westberg
A few days ago I posted an initial version of the necessary configuration required to run pre-submit build and tests for JDK main-line contributions using GitHub Actions [2] and the free tier [3] available to everyone working with open source repositories. I've incorporated the feedback into an u