Re: RFR: 8256048: Incomplete gitignore setting for netbeans project [v3]

2020-11-09 Thread Erik Joelsson
On Mon, 9 Nov 2020 23:31:09 GMT, Jie Fu wrote: >> Hi all, >> >> The gitignore setting for netbeans project seems to be incomplete. >> Only nbproject/private/ [1] is ignored. >> >> But there are also other files under nbproject/, which should be ignored too. >> >>

Re: RFR: 8256048: Incomplete gitignore setting for netbeans project [v3]

2020-11-09 Thread Jie Fu
On Mon, 9 Nov 2020 18:03:31 GMT, Erik Joelsson wrote: >> You misunderstand me. Adding the following line is fine and will make git >> ignore any nbproject dir in the root of the repository, which is what I >> assume you want: >> >> >> But removing the following existing line is not, as this

Re: RFR: 8256048: Incomplete gitignore setting for netbeans project [v3]

2020-11-09 Thread Jie Fu
> Hi all, > > The gitignore setting for netbeans project seems to be incomplete. > Only nbproject/private/ [1] is ignored. > > But there are also other files under nbproject/, which should be ignored too. > > $ tree -L 1 nbproject/ > nbproject/ > ├──

Re: RFR: 8256048: Incomplete gitignore setting for netbeans project [v2]

2020-11-09 Thread Erik Joelsson
On Mon, 9 Nov 2020 15:25:28 GMT, Jie Fu wrote: >> .gitignore line 5: >> >>> 3: /.idea/ >>> 4: /.vscode/ >>> 5: /nbproject/ >> >> I believe the existing nbproject/private/ is meant to catch any private >> files created by someone opening any of the various nbproject directories >> that exist

Re: RFR: 8256048: Incomplete gitignore setting for netbeans project [v2]

2020-11-09 Thread Erik Joelsson
On Mon, 9 Nov 2020 18:02:32 GMT, Erik Joelsson wrote: >> Thanks @erikj79 for your review. >> Updated. >> >> Any comments? >> Thanks. > > You misunderstand me. Adding the following line is fine and will make git > ignore any nbproject dir in the root of the repository, which is what I > assume

Re: RFR: 8256048: Incomplete gitignore setting for netbeans project [v2]

2020-11-09 Thread Jie Fu
On Mon, 9 Nov 2020 13:53:35 GMT, Erik Joelsson wrote: >> Jie Fu has updated the pull request incrementally with one additional commit >> since the last revision: >> >> Don't remove nbproject/private/ > > .gitignore line 5: > >> 3: /.idea/ >> 4: /.vscode/ >> 5: /nbproject/ > > I believe the

Re: RFR: 8256048: Incomplete gitignore setting for netbeans project [v2]

2020-11-09 Thread Jie Fu
> Hi all, > > The gitignore setting for netbeans project seems to be incomplete. > Only nbproject/private/ [1] is ignored. > > But there are also other files under nbproject/, which should be ignored too. > > $ tree -L 1 nbproject/ > nbproject/ > ├──

Re: RFR: 8256048: Incomplete gitignore setting for netbeans project

2020-11-09 Thread Erik Joelsson
On Mon, 9 Nov 2020 12:07:37 GMT, Jie Fu wrote: > Hi all, > > The gitignore setting for netbeans project seems to be incomplete. > Only nbproject/private/ [1] is ignored. > > But there are also other files under nbproject/, which should be ignored too. > > $ tree

RFR: 8256048: Incomplete gitignore setting for netbeans project

2020-11-09 Thread Jie Fu
Hi all, The gitignore setting for netbeans project seems to be incomplete. Only nbproject/private/ [1] is ignored. But there are also other files under nbproject/, which should be ignored too. $ tree -L 1 nbproject/ nbproject/ ├── configurations.xml ├── private └──