On Mon, 11 Jan 2021 18:56:38 GMT, Erik Joelsson wrote:
> There should be a dependency declaration added too. Something like this right
> after the SetupJdkLibrary macro call:
>
> $(BUILD_LIBOSXAPP): $(call FindLib, java.base, java)
Fixed.
-
PR:
On Mon, 11 Jan 2021 17:52:19 GMT, Phil Race wrote:
>> Proposed updates to JNI error handling.
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8259343: [macOS] Update JNI error handling in Cocoa code.
On Mon, 11 Jan 2021 05:58:28 GMT, Sergey Bylokhov wrote:
>> src/java.desktop/macosx/native/libosxapp/JNIUtilities.h line 46:
>>
>>> 44: if ((*env)->ExceptionOccurred(env) != NULL) { \
>>> 45: (*env)->ExceptionDescribe(env); \
>>> 46: } \
>>
>> So
On Mon, 11 Jan 2021 06:01:36 GMT, Sergey Bylokhov wrote:
>> I hadn't noticed that line - and definintely not realised it was recent.
>> I suppose he must have had a way to trigger it.
>> But I don't think it hurts to have both.
>
> I just tried to understand why we need to complicate this, to
> Proposed updates to JNI error handling.
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
8259343: [macOS] Update JNI error handling in Cocoa code.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1967/files
-
On Mon, 11 Jan 2021 05:52:02 GMT, Sergey Bylokhov wrote:
> Not sure that the check for ExceptionOccurred is needed,
It may not be needed in practice but if the code path is never taken no harm ...
in all other places where we check the ref to methods/field we only check the
return value, and
