Re: RFR: 8263097: Update JMH devkit to 1.28 [v2]

2021-03-08 Thread Claes Redestad
On Mon, 8 Mar 2021 14:18:27 GMT, Erik Joelsson wrote: >> Claes Redestad has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Keep jib-profiles in sync > > Marked as reviewed by erikj (Reviewer). Thank you for reviewing, Eric and Erik! -

Re: RFR: 8263097: Update JMH devkit to 1.28 [v2]

2021-03-08 Thread Erik Joelsson
On Fri, 5 Mar 2021 19:25:26 GMT, Claes Redestad wrote: >> Currently at 1.26, so there are a few good improvements and a few bug fixes >> - notably resolving a build reproducibility issue. > > Claes Redestad has updated the pull request incrementally with one additional > commit since the last r

Re: RFR: 8263097: Update JMH devkit to 1.28 [v2]

2021-03-08 Thread Claes Redestad
On Fri, 5 Mar 2021 17:25:02 GMT, Erik Joelsson wrote: >> Good! >> Eric > > Should also updated jib-profiles.js Oracle builds get the new version. Uploaded and verified jib picks up the new version. - PR: https://git.openjdk.java.net/jdk/pull/2848

Re: RFR: 8263097: Update JMH devkit to 1.28 [v2]

2021-03-05 Thread Claes Redestad
> Currently at 1.26, so there are a few good improvements and a few bug fixes - > notably resolving a build reproducibility issue. Claes Redestad has updated the pull request incrementally with one additional commit since the last revision: Keep jib-profiles in sync - Changes:

Re: RFR: 8263097: Update JMH devkit to 1.28

2021-03-05 Thread Erik Joelsson
On Fri, 5 Mar 2021 16:11:38 GMT, Eric Caspole wrote: >> Currently at 1.26, so there are a few good improvements and a few bug fixes >> - notably resolving a build reproducibility issue. > > Good! > Eric Should also updated jib-profiles.js Oracle builds get the new version. - PR: h

Re: RFR: 8263097: Update JMH devkit to 1.28

2021-03-05 Thread Eric Caspole
On Fri, 5 Mar 2021 16:04:49 GMT, Claes Redestad wrote: > Currently at 1.26, so there are a few good improvements and a few bug fixes - > notably resolving a build reproducibility issue. Good! Eric - Marked as reviewed by ecaspole (Committer). PR: https://git.openjdk.java.net/jdk/

RFR: 8263097: Update JMH devkit to 1.28

2021-03-05 Thread Claes Redestad
Currently at 1.26, so there are a few good improvements and a few bug fixes - notably resolving a build reproducibility issue. - Commit messages: - Update JMH devkit to 1.28 Changes: https://git.openjdk.java.net/jdk/pull/2848/files Webrev: https://webrevs.openjdk.java.net/?repo=jd