On Fri, 3 Jun 2022 07:56:38 GMT, Tim Prinzing wrote:
> Fixed JtregNativeJdk.gmk to include c++ libs for NullCallerTest
There are a few C++ tests under `test/jdk/java/foreign` as well.
-
PR: https://git.openjdk.java.net/jdk/pull/9010
On Mon, 6 Jun 2022 15:56:47 GMT, Tim Prinzing wrote:
> The idea was to reduce duplicate code. Changing to use objects to encapsulate
> the up calls got rid of a lot of repeated code and made things simpler and
> clearer. Objects are created with the class, method, and signature strings
> and
On Mon, 6 Jun 2022 07:45:16 GMT, David Holmes wrote:
> Hi Tim,
>
> Sorry but I have to ask why this test was created as a C++ program instead of
> keeping it as a C program likes it predecessors? No need for C++ libs or
> special exception handling flags in that case.
The idea was to reduce
On Fri, 3 Jun 2022 07:56:38 GMT, Tim Prinzing wrote:
> Fixed JtregNativeJdk.gmk to include c++ libs for NullCallerTest
Hi Tim,
Sorry but I have to ask why this test was created as a C++ program instead of
keeping it as a C program likes it predecessors? No need for C++ libs or
special
On Fri, 3 Jun 2022 22:40:52 GMT, Tim Prinzing wrote:
>> make/test/JtregNativeJdk.gmk line 67:
>>
>>> 65: BUILD_JDK_JTREG_EXECUTABLES_LIBS_exeNullCallerTest := $(LIBCXX)
>>> jvm.lib
>>> 66: BUILD_JDK_JTREG_EXECUTABLES_LIBS_exerevokeall := advapi32.lib
>>> 67:
On Fri, 3 Jun 2022 18:16:53 GMT, Mandy Chung wrote:
>> Fixed JtregNativeJdk.gmk to include c++ libs for NullCallerTest
>
> make/test/JtregNativeJdk.gmk line 67:
>
>> 65: BUILD_JDK_JTREG_EXECUTABLES_LIBS_exeNullCallerTest := $(LIBCXX) jvm.lib
>> 66:
On Fri, 3 Jun 2022 07:56:38 GMT, Tim Prinzing wrote:
> Fixed JtregNativeJdk.gmk to include c++ libs for NullCallerTest
Thanks for doing the run, Dan.
-
PR: https://git.openjdk.java.net/jdk/pull/9010
On Fri, 3 Jun 2022 07:56:38 GMT, Tim Prinzing wrote:
> Fixed JtregNativeJdk.gmk to include c++ libs for NullCallerTest
I did a Mach5 Tier1 test run on the v00 version of this patch. There were
no failures and all 6 runs of jni/nullCaller/NullCallerTest.java passed.
-
PR:
On Fri, 3 Jun 2022 07:56:38 GMT, Tim Prinzing wrote:
> Fixed JtregNativeJdk.gmk to include c++ libs for NullCallerTest
Marked as reviewed by mchung (Reviewer).
make/test/JtregNativeJdk.gmk line 67:
> 65: BUILD_JDK_JTREG_EXECUTABLES_LIBS_exeNullCallerTest := $(LIBCXX) jvm.lib
> 66:
On Fri, 3 Jun 2022 07:56:38 GMT, Tim Prinzing wrote:
> Fixed JtregNativeJdk.gmk to include c++ libs for NullCallerTest
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/9010
Fixed JtregNativeJdk.gmk to include c++ libs for NullCallerTest
-
Commit messages:
- 8287745 Fix JtregNativeJdk.gmk to include c++ libs for NullCallerTest
Changes: https://git.openjdk.java.net/jdk/pull/9010/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=9010=00
Issue:
11 matches
Mail list logo