Hi Magnus:
I read the .patch files since that was the best way to see everything.
Massive set of changes, but this looks good to me it if builds. Approved.
Tim
I found a couple of more places with the same issue, all in the jdk
repository.
New webrev for jdk:
http://cr.openjdk.java.net/~i
I found a couple of more places with the same issue, all in the jdk
repository.
New webrev for jdk:
http://cr.openjdk.java.net/~ihse/JDK-8001931-build-infra-whitespace-cleanup/jdk/webrev.02
Webrev showing diff between this and previous webrev:
http://cr.openjdk.java.net/~ihse/JDK-8001931-bui
Resending, since it seems to have disappeared on the way. Sorry if it
reaches you twice.
On 2013-10-08 11:53, Volker Simonis wrote:
I've just started looking into this, but if I understand point 5:
5) Non-shell commands in a recipe (e.g. comments and make directives
like ifdef) must not start
Hi,
First of all just a little hint to other reviewers - only the "patch"-view
really shows all the changes. All the other views (Cdiffs, Udiffs, Sdiffs,
Frames) show much less and are sometimes even empty!
I've just started looking into this, but if I understand point 5:
5) Non-shell commands i
Based on the code conventions posted earlier, Erik and I have made a
complete overhaul on the use of whitespace and indentation in the new
build system.
We set up an important limitation on this change: *only* whitespace
should be changed. This self-imposed limitation helped us verify that
no
