On 2014-02-04 00:11, Xueming Shen wrote:
Changeset looks fine. Thanks for doing this.
Thanks for the review.
Potentially it might worth considering to move two template files
DoubleByte/SingleByte-X.java.template into the corresponding source
code directory as well. But they can be dealt wit
Changeset looks fine. Thanks for doing this.
Potentially it might worth considering to move two template files
DoubleByte/SingleByte-X.java.template into the corresponding source
code directory as well. But they can be dealt with later. We should
migrate the StandardCharsets generating code from
I can't verify that the changes are correct but the resulting build does seem
to work for me.
Can you remove this (now) inaccurate comment in Hasher.java :
46 // This class cannot, sadly, make use of 1.5 features since it must be
47 // compiled and run with the bootstrap JDK, which i
From a build point of view, this looks good at least.
/Erik
On 2014-01-30 15:29, Alan Bateman wrote:
I think it's important that Sherman is at least one of the reviewers
on this.
-Alan.
On 30/01/2014 14:18, Magnus Ihse Bursie wrote:
The file GensrcCharsetMapping.gmk was not properly conver
I think it's important that Sherman is at least one of the reviewers on
this.
-Alan.
On 30/01/2014 14:18, Magnus Ihse Bursie wrote:
The file GensrcCharsetMapping.gmk was not properly converted from the
old build system.
This leads to unneccessary output, incorrect dependencies, missed
cha
The file GensrcCharsetMapping.gmk was not properly converted from the
old build system.
This leads to unneccessary output, incorrect dependencies, missed
chances for parallelization. It also breaks certain attempts to run
static code analyzers such as Parfait.
This change introduces the new
