Re: RFR: JDK-8034199 Add 'reconfigure' target for re-creating a configuration

2014-02-17 Thread Magnus Ihse Bursie
On 2014-02-17 03:10, David Holmes wrote: Presumably the right way to do this would be: "make clean reconfigure ..." otherwise you could get some kind of weird hybrid build. I'm not sure that every change in spec.gmk, for example would force a recompile of everything that depended on something

Re: RFR: JDK-8034199 Add 'reconfigure' target for re-creating a configuration

2014-02-17 Thread Erik Joelsson
On 2014-02-17 03:10, David Holmes wrote: On 12/02/2014 11:36 PM, Magnus Ihse Bursie wrote: Sometimes we need to re-run configure, due to changes in configure files. Make detects such changes and forces a new run of configure. If configure was run with a long command line, it's tricky to get th

Re: RFR: JDK-8034199 Add 'reconfigure' target for re-creating a configuration

2014-02-16 Thread David Holmes
On 12/02/2014 11:36 PM, Magnus Ihse Bursie wrote: Sometimes we need to re-run configure, due to changes in configure files. Make detects such changes and forces a new run of configure. If configure was run with a long command line, it's tricky to get this right again. However, this can be done a

Re: RFR: JDK-8034199 Add 'reconfigure' target for re-creating a configuration

2014-02-13 Thread Tim Bell
Hi Magnus: Looks good to me as well. Tim On 02/13/14 02:30 AM, Erik Joelsson wrote: Looks even better to me. /Erik On 2014-02-12 23:31, Magnus Ihse Bursie wrote: On 2014-02-12 19:19, Martin Buchholz wrote: I'm not sure exactly what the problem is, but do you need a contribution like this

Re: RFR: JDK-8034199 Add 'reconfigure' target for re-creating a configuration

2014-02-13 Thread Erik Joelsson
Looks even better to me. /Erik On 2014-02-12 23:31, Magnus Ihse Bursie wrote: On 2014-02-12 19:19, Martin Buchholz wrote: I'm not sure exactly what the problem is, but do you need a contribution like this: Yeah, something like that. :-) Thanks! I knew something like that was needed, but I di

Re: RFR: JDK-8034199 Add 'reconfigure' target for re-creating a configuration

2014-02-12 Thread Magnus Ihse Bursie
On 2014-02-12 19:19, Martin Buchholz wrote: I'm not sure exactly what the problem is, but do you need a contribution like this: Yeah, something like that. :-) Thanks! I knew something like that was needed, but I did not feel like writing it. I took your snipped and adapted it slightly, to imp

Re: RFR: JDK-8034199 Add 'reconfigure' target for re-creating a configuration

2014-02-12 Thread Mike Duigou
On Feb 12 2014, at 09:31 , Henry Jen wrote: > On 02/12/2014 07:11 AM, Magnus Ihse Bursie wrote: >> 12 feb 2014 kl. 14:55 skrev Erik Joelsson : >> >>> First I was disappointed to lose the configure-arguments file, which I >>> sometimes look in to see how configure was run, but I can just as wel

Re: RFR: JDK-8034199 Add 'reconfigure' target for re-creating a configuration

2014-02-12 Thread Henry Jen
On 02/12/2014 07:11 AM, Magnus Ihse Bursie wrote: 12 feb 2014 kl. 14:55 skrev Erik Joelsson : First I was disappointed to lose the configure-arguments file, which I sometimes look in to see how configure was run, but I can just as well look in spec.gmk. Yes, that was my own reaction too. :-

Re: RFR: JDK-8034199 Add 'reconfigure' target for re-creating a configuration

2014-02-12 Thread Magnus Ihse Bursie
12 feb 2014 kl. 14:55 skrev Erik Joelsson : > First I was disappointed to lose the configure-arguments file, which I > sometimes look in to see how configure was run, but I can just as well look > in spec.gmk. Yes, that was my own reaction too. :-) "Hey, I can't remove that". :) I'm not even

Re: RFR: JDK-8034199 Add 'reconfigure' target for re-creating a configuration

2014-02-12 Thread Erik Joelsson
Looks good to me. First I was disappointed to lose the configure-arguments file, which I sometimes look in to see how configure was run, but I can just as well look in spec.gmk. Have you tried running with complex arguments, like --with-extra-cflags="-flag1 -flag2"? /Erik On 2014-02-12 14

RFR: JDK-8034199 Add 'reconfigure' target for re-creating a configuration

2014-02-12 Thread Magnus Ihse Bursie
Sometimes we need to re-run configure, due to changes in configure files. Make detects such changes and forces a new run of configure. If configure was run with a long command line, it's tricky to get this right again. However, this can be done automatically by the Makefile. By adding a new t