Re: RFR: JDK-8055922: Work around sjavac limitation with public api tracking cross modules

2014-08-27 Thread Joel Borggrén-Franck
Can’t really comment on the makefile changes but I think this workaround is good for now. Thumbs up cheers /Joel On 26 aug 2014, at 11:58, Erik Joelsson wrote: > Updated webrev: http://cr.openjdk.java.net/~erikj/8055922/webrev.root.02/ > > Some of the demos failed to compile because the javac

Re: RFR: JDK-8055922: Work around sjavac limitation with public api tracking cross modules

2014-08-26 Thread Magnus Ihse Bursie
On 2014-08-26 11:58, Erik Joelsson wrote: Updated webrev: http://cr.openjdk.java.net/~erikj/8055922/webrev.root.02/ Some of the demos failed to compile because the javac_state file did not contain any public api and this caused grep to exit with code 1, which failed the build. I made exit code

Re: RFR: JDK-8055922: Work around sjavac limitation with public api tracking cross modules

2014-08-26 Thread Erik Joelsson
Updated webrev: http://cr.openjdk.java.net/~erikj/8055922/webrev.root.02/ Some of the demos failed to compile because the javac_state file did not contain any public api and this caused grep to exit with code 1, which failed the build. I made exit code 1 for this grep line not fail the build.

RFR: JDK-8055922: Work around sjavac limitation with public api tracking cross modules

2014-08-25 Thread Erik Joelsson
Hello, Please review this little workaround for a current shortcoming in Sjavac. See bug for more details. With this change, Sjavac will start acting correctly again and not miss any files that need to be recompiled. The approximation is course however, we should still fix https://bugs.openjd