Re: RFR: JDK-8069261: Create make dependencies on make variable values

2015-01-23 Thread Magnus Ihse Bursie
On 2015-01-23 14:35, Erik Joelsson wrote: Hello, New webrev: On 2015-01-23 13:34, Magnus Ihse Bursie wrote: On 2015-01-23 12:17, Erik Joelsson wrote: * Added test-make to the all target so that it gets tested in JPRT. It takes close to no time to run. While I do like to see the make tests bei

Re: RFR: JDK-8069261: Create make dependencies on make variable values

2015-01-23 Thread Erik Joelsson
And the webrev link: http://cr.openjdk.java.net/~erikj/8069261/webrev.03/ /Erik On 2015-01-23 14:35, Erik Joelsson wrote: Hello, New webrev: On 2015-01-23 13:34, Magnus Ihse Bursie wrote: On 2015-01-23 12:17, Erik Joelsson wrote: * Added test-make to the all target so that it gets tested in

Re: RFR: JDK-8069261: Create make dependencies on make variable values

2015-01-23 Thread Erik Joelsson
Hello, New webrev: On 2015-01-23 13:34, Magnus Ihse Bursie wrote: On 2015-01-23 12:17, Erik Joelsson wrote: * Added test-make to the all target so that it gets tested in JPRT. It takes close to no time to run. While I do like to see the make tests being run more frequently, I'm not sure I lik

Re: RFR: JDK-8069261: Create make dependencies on make variable values

2015-01-23 Thread Magnus Ihse Bursie
On 2015-01-23 12:17, Erik Joelsson wrote: Hello, Thanks for the comments. Here is a new version: http://cr.openjdk.java.net/~erikj/8069261/webrev.02/ In addition to fixing the concerns below, I fixed the following: * Added test-make to the all target so that it gets tested in JPRT. It takes c

Re: RFR: JDK-8069261: Create make dependencies on make variable values

2015-01-23 Thread Erik Joelsson
Hello, Thanks for the comments. Here is a new version: http://cr.openjdk.java.net/~erikj/8069261/webrev.02/ In addition to fixing the concerns below, I fixed the following: * Added test-make to the all target so that it gets tested in JPRT. It takes close to no time to run. * Added 1 second

Re: RFR: JDK-8069261: Create make dependencies on make variable values

2015-01-21 Thread Magnus Ihse Bursie
On 2015-01-19 14:33, Erik Joelsson wrote: Hello, Please review this enhancement to the incremental build correctness. I have implemented a way to track make dependencies to make variable values, so that relevant changes to makefiles or configure will properly trigger rebuilds of affected targ

RFR: JDK-8069261: Create make dependencies on make variable values

2015-01-19 Thread Erik Joelsson
Hello, Please review this enhancement to the incremental build correctness. I have implemented a way to track make dependencies to make variable values, so that relevant changes to makefiles or configure will properly trigger rebuilds of affected targets. See bug description for more details.