Re: RFR: JDK-8145549 Add support for Visual Studio 2015 Community edition

2016-01-14 Thread Wang Weijun
> On Jan 14, 2016, at 11:00 PM, Magnus Ihse Bursie > wrote: > > On 2015-12-18 15:11, Wang Weijun wrote: >> Hi Vinnie >> >> I take a look and it includes a change for >> src/jdk.crypto.mscapi/windows/native/libsunmscapi/security.cpp in the >> Java_sun_security_mscapi_KeyStore_getKeyLength() f

Re: RFR: JDK-8145549 Add support for Visual Studio 2015 Community edition

2016-01-14 Thread Magnus Ihse Bursie
On 2016-01-05 03:25, Kim Barrett wrote: On Dec 18, 2015, at 7:41 PM, Kim Barrett wrote: On Dec 16, 2015, at 8:50 AM, Magnus Ihse Bursie wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8145549 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8145549-vs2015-community-edition/webrev.01 /Magn

Re: RFR: JDK-8145549 Add support for Visual Studio 2015 Community edition

2016-01-14 Thread Magnus Ihse Bursie
On 2015-12-18 15:11, Wang Weijun wrote: Hi Vinnie I take a look and it includes a change for src/jdk.crypto.mscapi/windows/native/libsunmscapi/security.cpp in the Java_sun_security_mscapi_KeyStore_getKeyLength() function. It seems there is no sun.security.mscapi.KeyStore#getKeyLength on the j

Re: RFR: JDK-8145549 Add support for Visual Studio 2015 Community edition

2016-01-04 Thread Kim Barrett
On Dec 18, 2015, at 7:41 PM, Kim Barrett wrote: > > On Dec 16, 2015, at 8:50 AM, Magnus Ihse Bursie > wrote: >> Bug: https://bugs.openjdk.java.net/browse/JDK-8145549 >> WebRev: >> http://cr.openjdk.java.net/~ihse/JDK-8145549-vs2015-community-edition/webrev.01 >> >> /Magnus > > I only looked

Re: RFR: JDK-8145549 Add support for Visual Studio 2015 Community edition

2015-12-18 Thread Kim Barrett
On Dec 16, 2015, at 8:50 AM, Magnus Ihse Bursie wrote: > > There is an interest from the community to build OpenJDK using Visual Studio > 2015 Community edition. > > This patch is provided by Timo Kinnunen . I am > sponsoring this patch. > > The changes to the source code files are mostly c

Re: RFR: JDK-8145549 Add support for Visual Studio 2015 Community edition

2015-12-18 Thread Wang Weijun
Hi Vinnie I take a look and it includes a change for src/jdk.crypto.mscapi/windows/native/libsunmscapi/security.cpp in the Java_sun_security_mscapi_KeyStore_getKeyLength() function. It seems there is no sun.security.mscapi.KeyStore#getKeyLength on the java side. Is the function useless now? T

Re: RFR: JDK-8145549 Add support for Visual Studio 2015 Community edition

2015-12-18 Thread Magnus Ihse Bursie
On 2015-12-16 14:50, Magnus Ihse Bursie wrote: There is an interest from the community to build OpenJDK using Visual Studio 2015 Community edition. This patch is provided by Timo Kinnunen . I am sponsoring this patch. The changes to the source code files are mostly casts to uintptr_t, but the

Re: RFR: JDK-8145549 Add support for Visual Studio 2015 Community edition

2015-12-16 Thread Erik Joelsson
The configure change looks good. Can't comment on the code changes. /Erik On 2015-12-16 14:50, Magnus Ihse Bursie wrote: There is an interest from the community to build OpenJDK using Visual Studio 2015 Community edition. This patch is provided by Timo Kinnunen . I am sponsoring this patch.

RFR: JDK-8145549 Add support for Visual Studio 2015 Community edition

2015-12-16 Thread Magnus Ihse Bursie
There is an interest from the community to build OpenJDK using Visual Studio 2015 Community edition. This patch is provided by Timo Kinnunen . I am sponsoring this patch. The changes to the source code files are mostly casts to uintptr_t, but there are some other changes as well. I'm not qui