Re: RFR: JDK-8159544: Remove deprecated classes in com.sun.security.auth.**

2017-08-18 Thread Sean Mullan
On 8/18/17 8:31 AM, Jan Lahoda wrote: For the langtools change, I think we shouldn't remove the entries from the include.list. This list defines which packages/classes should and should not be available when compiling for previous versions of the platform using --release. The removed entries ar

Re: RFR: JDK-8159544: Remove deprecated classes in com.sun.security.auth.**

2017-08-18 Thread Sean Mullan
On 8/17/17 8:16 PM, Weijun Wang wrote: Hi Sean Change looks fine. And I found another 4 references in comments in jdk/src/java.base/share/classes/javax/security/auth/Policy.java. Good catch. I changed SolarisPrincipal and SolarisNumericUserPrincipal to UnixPrincipal and UnixNumericUserPrinc

Re: RFR: JDK-8159544: Remove deprecated classes in com.sun.security.auth.**

2017-08-18 Thread Jan Lahoda
For the langtools change, I think we shouldn't remove the entries from the include.list. This list defines which packages/classes should and should not be available when compiling for previous versions of the platform using --release. The removed entries are exclude entries, so if removed, it w

Re: RFR: JDK-8159544: Remove deprecated classes in com.sun.security.auth.**

2017-08-18 Thread Vincent Ryan
Your changes look fine to me. Thanks. > On 17 Aug 2017, at 20:08, Sean Mullan wrote: > > Please review this JDK 10 change to remove the deprecated classes in > com.sun.security.auth.** that have been previously marked with > forRemoval=true in JDK 9. > > webrev: http://cr.openjdk.java.net/~m

Re: RFR: JDK-8159544: Remove deprecated classes in com.sun.security.auth.**

2017-08-17 Thread Weijun Wang
Hi Sean Change looks fine. And I found another 4 references in comments in jdk/src/java.base/share/classes/javax/security/auth/Policy.java. BTW, do we have a test to show what lines in various Resources.java files are used where and if one is useless? Thanks Max > On Aug 18, 2017, at 3:08 AM

RFR: JDK-8159544: Remove deprecated classes in com.sun.security.auth.**

2017-08-17 Thread Sean Mullan
Please review this JDK 10 change to remove the deprecated classes in com.sun.security.auth.** that have been previously marked with forRemoval=true in JDK 9. webrev: http://cr.openjdk.java.net/~mullan/webrevs/8159544/ I have also copied Jan for reviewing a change in langtools, and also build-