Re: RFR: JDK-8166948: Exploded image too slow to be usable

2016-10-04 Thread Magnus Ihse Bursie
On 2016-09-30 16:06, Erik Joelsson wrote: Hello, I missed adding a dependency for the cross compilation case. The change is in Main.gmk, adding the line: + buildtools-modules: create-buildjdk New webrev: http://cr.openjdk.java.net/~erikj/8166948/webrev.02/ Looks good to me. /Magnus

Re: RFR: JDK-8166948: Exploded image too slow to be usable

2016-09-30 Thread Mandy Chung
> On Sep 30, 2016, at 7:06 AM, Erik Joelsson wrote: > > New webrev: http://cr.openjdk.java.net/~erikj/8166948/webrev.02/ > This change looks good. It’s a good speedup. Thanks for cleaning up the duplicated TOOL_GENGRAPHS and TOOL_MODULESUMMARY definition. Mandy

Re: RFR: JDK-8166948: Exploded image too slow to be usable

2016-09-30 Thread Alan Bateman
On 30/09/2016 15:06, Erik Joelsson wrote: Hello, I missed adding a dependency for the cross compilation case. The change is in Main.gmk, adding the line: + buildtools-modules: create-buildjdk New webrev: http://cr.openjdk.java.net/~erikj/8166948/webrev.02/ Looks okay.

Re: RFR: JDK-8166948: Exploded image too slow to be usable

2016-09-30 Thread Erik Joelsson
Hello, I missed adding a dependency for the cross compilation case. The change is in Main.gmk, adding the line: + buildtools-modules: create-buildjdk New webrev: http://cr.openjdk.java.net/~erikj/8166948/webrev.02/ /Erik On 2016-09-30 10:03, Erik Joelsson wrote: During the build proces

Re: RFR: JDK-8166948: Exploded image too slow to be usable

2016-09-30 Thread Erik Joelsson
On 2016-09-30 12:06, Alan Bateman wrote: On 30/09/2016 09:03, Erik Joelsson wrote: During the build process, we create an exploded image as an interim step before linking the real JDK and JRE images. This exploded image is used both for running certain build tools during the build but is a

Re: RFR: JDK-8166948: Exploded image too slow to be usable

2016-09-30 Thread Chris Hegarty
On 30/09/16 10:47, Alan Bateman wrote: On 30/09/2016 10:43, Chris Hegarty wrote: ... Additionally, do you want to run with --add-modules java.se.ee to include the 6 "EE" modules? Not needed as the tool adds the class file attribute to every module-info.class in jdk/modules/*. Ah ok, go it. T

Re: RFR: JDK-8166948: Exploded image too slow to be usable

2016-09-30 Thread Alan Bateman
On 30/09/2016 09:03, Erik Joelsson wrote: During the build process, we create an exploded image as an interim step before linking the real JDK and JRE images. This exploded image is used both for running certain build tools during the build but is also used by developers when needing a quick b

Re: RFR: JDK-8166948: Exploded image too slow to be usable

2016-09-30 Thread Alan Bateman
On 30/09/2016 10:43, Chris Hegarty wrote: Ooh, this is quite clever, levering the already computed packages list from the running VM to add the packages attribute to the module info. One minor concern ( which I think should be ok ) is the updating of the module-info.class files of the running

Re: RFR: JDK-8166948: Exploded image too slow to be usable

2016-09-30 Thread Chris Hegarty
On 30/09/16 09:03, Erik Joelsson wrote: During the build process, we create an exploded image as an interim step before linking the real JDK and JRE images. This exploded image is used both for running certain build tools during the build but is also used by developers when needing a quick build-

RFR: JDK-8166948: Exploded image too slow to be usable

2016-09-30 Thread Erik Joelsson
During the build process, we create an exploded image as an interim step before linking the real JDK and JRE images. This exploded image is used both for running certain build tools during the build but is also used by developers when needing a quick build-test cycle since the exploded image is