Re: RFR: JDK-8175036 All API docs should be built for HTML 5

2017-04-24 Thread Martin Buchholz
On Mon, Apr 24, 2017 at 5:06 PM, Jonathan Gibbons < jonathan.gibb...@oracle.com> wrote: > There is also a very strong desire to move to HTML 5 for the JDK > documentation to be able to make use of the accessibility features that are > available. > OK, that's a good reason to do it sooner rather th

Re: RFR: JDK-8175036 All API docs should be built for HTML 5

2017-04-24 Thread Jonathan Gibbons
Martin No one disputes that we need to clean up the HTML in our doc comments. There is also a very strong desire to move to HTML 5 for the JDK documentation to be able to make use of the accessibility features that are available. The only issue is how to get there from here and how quickly

Re: RFR: JDK-8175036 All API docs should be built for HTML 5

2017-04-24 Thread Martin Buchholz
[+javadoc-dev] I'm no html expert, so don't trust anything I say, but: jdk9 javadoc contains constructs that are clearly invalid html5, so generating html5 output creates invalid web pages; they must be cleaned up first. Someone around here must have the expertise to know how best to write moder

Re: RFR: JDK-8175036 All API docs should be built for HTML 5

2017-04-24 Thread Jonathan Gibbons
I'll open a separate bug, but we'll have to decide how we sequence this. It's already the case that we've mostly disabled doclint in javadoc, so it is not significantly worse to disable it in javac for the time being as well, until we get everything sorted out and consistent. -- Jon On 04/21

Re: RFR: JDK-8175036 All API docs should be built for HTML 5

2017-04-23 Thread Magnus Ihse Bursie
Martin, Does this mean you oppose this change until all Javadoc compiles cleanly with doclint html5? /Magnus > 22 apr. 2017 kl. 19:11 skrev Martin Buchholz : > > It seems our javadoc is using html constructs that are not valid html5. If > so, we should convert all of those before we start ge

Re: RFR: JDK-8175036 All API docs should be built for HTML 5

2017-04-22 Thread Martin Buchholz
It seems our javadoc is using html constructs that are not valid html5. If so, we should convert all of those before we start generating html5 output. That should not be too much work for someone who actually understands css and html5. On Fri, Apr 21, 2017 at 2:30 AM, Magnus Ihse Bursie < magnus

Re: RFR: JDK-8175036 All API docs should be built for HTML 5

2017-04-21 Thread Magnus Ihse Bursie
Jon, Can you please open a separate bug for this? Just adding --doclint-format html5 generates a lot of failures, as Martin points out, so it's not feasible to do as part of this fix. /Magnus On 2017-04-21 03:08, Martin Buchholz wrote: There would be a global cleanup involved for --doclint-

Re: RFR: JDK-8175036 All API docs should be built for HTML 5

2017-04-21 Thread Erik Joelsson
Looks good to me. /Erik On 2017-04-21 00:20, Magnus Ihse Bursie wrote: We should switch all uses of the javadoc tool to generate documentation in HTML 5, using the -html5 option. Bug: https://bugs.openjdk.java.net/browse/JDK-8175036 Patch inline: diff --git a/make/Javadoc.gmk b/make/Javadoc.

Re: RFR: JDK-8175036 All API docs should be built for HTML 5

2017-04-20 Thread Martin Buchholz
There would be a global cleanup involved for --doclint-format html5 A CSS expert can probably suggest replacements. [javac] ... src/main/java/util/Deque.java:30: error: attribute border for table only accepts "" or "1", use CSS instead: BORDER [javac] * On Thu, Apr 20, 2017 at 3:42 PM,

Re: RFR: JDK-8175036 All API docs should be built for HTML 5

2017-04-20 Thread Jonathan Gibbons
We probably want to set --doclint-format html5 for javac as well, for the benefit of compilations that run doclint. -- Jon On 4/20/17 3:20 PM, Magnus Ihse Bursie wrote: We should switch all uses of the javadoc tool to generate documentation in HTML 5, using the -html5 option. Bug: https://

RFR: JDK-8175036 All API docs should be built for HTML 5

2017-04-20 Thread Magnus Ihse Bursie
We should switch all uses of the javadoc tool to generate documentation in HTML 5, using the -html5 option. Bug: https://bugs.openjdk.java.net/browse/JDK-8175036 Patch inline: diff --git a/make/Javadoc.gmk b/make/Javadoc.gmk --- a/make/Javadoc.gmk +++ b/make/Javadoc.gmk @@ -84,7 +84,7 @@ # The