On Tue, 15 Dec 2020 08:20:54 GMT, Magnus Ihse Bursie wrote:
> Build changes look good.
>
> I left a note on the hotspot code; feel free to ignore it if you want. :)
>
> I agree with your assessment that restoring gtest to the code base would make
> life simpler. I'm not sure what needs to be d
On Tue, 15 Dec 2020 08:16:51 GMT, Magnus Ihse Bursie wrote:
>> Hi,
>>
>> May I have reviews please for the following patch.
>>
>> At the moment, if a crash happens on Windows in gtests, the gtest SEH
>> handler may be invoked instead of our error handler, and we just see a
>> one-line-warning
On Sun, 13 Dec 2020 11:07:42 GMT, Thomas Stuefe wrote:
> Hi,
>
> May I have reviews please for the following patch.
>
> At the moment, if a crash happens on Windows in gtests, the gtest SEH handler
> may be invoked instead of our error handler, and we just see a
> one-line-warning "SEH happen
On Sun, 13 Dec 2020 11:07:42 GMT, Thomas Stuefe wrote:
> Hi,
>
> May I have reviews please for the following patch.
>
> At the moment, if a crash happens on Windows in gtests, the gtest SEH handler
> may be invoked instead of our error handler, and we just see a
> one-line-warning "SEH happen
On Mon, 14 Dec 2020 04:52:02 GMT, David Holmes wrote:
> Hi Thomas,
> Not an expert but this all seems quite reasonable to me.
> Thanks,
> David
Thanks David!
-
PR: https://git.openjdk.java.net/jdk/pull/1757
On Sun, 13 Dec 2020 11:07:42 GMT, Thomas Stuefe wrote:
> Hi,
>
> May I have reviews please for the following patch.
>
> At the moment, if a crash happens on Windows in gtests, the gtest SEH handler
> may be invoked instead of our error handler, and we just see a
> one-line-warning "SEH happen
Hi,
May I have reviews please for the following patch.
At the moment, if a crash happens on Windows in gtests, the gtest SEH handler
may be invoked instead of our error handler, and we just see a one-line-warning
"SEH happened blabala". No hs-err file.
Even worse, if a crash happens inside the
