Re: RFR: JDK-8188012 Nashorn build targets version 9 source

2017-09-27 Thread David Holmes
On 27/09/2017 7:26 PM, Magnus Ihse Bursie wrote: On 2017-09-27 10:55, David Holmes wrote: On 27/09/2017 6:30 PM, Magnus Ihse Bursie wrote: The nashorn java code requires a somewhat convoluted compilation. As a result, we use a special java compiler setup, GENERATE_NEWBYTECODE_DEBUG. This e

Re: RFR: JDK-8188012 Nashorn build targets version 9 source

2017-09-27 Thread Sundararajan Athijegannathan
We run nasgen tool on the generated nashorn .class files to post-process. nasgen used to run on boot JDK in the past (if I recall right). I'm fine with current change is okay - so long as nasgen works fine & nashorn tests run fine. Please note that nashorn tests are run with "ant". cd $jd

Re: RFR: JDK-8188012 Nashorn build targets version 9 source

2017-09-27 Thread Magnus Ihse Bursie
On 2017-09-27 10:55, David Holmes wrote: On 27/09/2017 6:30 PM, Magnus Ihse Bursie wrote: The nashorn java code requires a somewhat convoluted compilation. As a result, we use a special java compiler setup, GENERATE_NEWBYTECODE_DEBUG. This explicitly lists -source 9 -target 9, which generate

Re: RFR: JDK-8188012 Nashorn build targets version 9 source

2017-09-27 Thread David Holmes
On 27/09/2017 6:30 PM, Magnus Ihse Bursie wrote: The nashorn java code requires a somewhat convoluted compilation. As a result, we use a special java compiler setup, GENERATE_NEWBYTECODE_DEBUG. This explicitly lists -source 9 -target 9, which generates this warning: warning: [options] boots

Re: RFR: JDK-8188012 Nashorn build targets version 9 source

2017-09-27 Thread Erik Joelsson
Looks good. /Erik On 2017-09-27 10:30, Magnus Ihse Bursie wrote: The nashorn java code requires a somewhat convoluted compilation. As a result, we use a special java compiler setup, GENERATE_NEWBYTECODE_DEBUG. This explicitly lists -source 9 -target 9, which generates this warning: warni

RFR: JDK-8188012 Nashorn build targets version 9 source

2017-09-27 Thread Magnus Ihse Bursie
The nashorn java code requires a somewhat convoluted compilation. As a result, we use a special java compiler setup, GENERATE_NEWBYTECODE_DEBUG. This explicitly lists -source 9 -target 9, which generates this warning: warning: [options] bootstrap class path not set in conjunction with -sour