Re: RFR: JDK-8189263 Introduce CUSTOM_ROOT

2017-10-13 Thread Erik Joelsson
Looks good. /Erik On 2017-10-13 12:11, Magnus Ihse Bursie wrote: To support the use case where the OpenJDK repository is included as part of a custom project, this patch introduces the concept of a "custom root", which plays the role of $TOPDIR in some circumstances. It is the responsibility

Re: RFR: JDK-8189263 Introduce CUSTOM_ROOT

2017-10-13 Thread David Holmes
Thanks for the explanation Magnus. David On 13/10/2017 11:34 PM, Magnus Ihse Bursie wrote: On 2017-10-13 15:08, David Holmes wrote: Hi Magnus, I find this all very confusing - we have a number of CUSTOM_* variables now and I would expect they to be closely tied together. With this patch

Re: RFR: JDK-8189263 Introduce CUSTOM_ROOT

2017-10-13 Thread Magnus Ihse Bursie
On 2017-10-13 15:08, David Holmes wrote: Hi Magnus, I find this all very confusing - we have a number of CUSTOM_* variables now and I would expect they to be closely tied together. With this patch, we have three: CUSTOM_ROOT, CUSTOM_CONFIG_DIR and CUSTOM_MAKE_DIR. We could boil that down

Re: RFR: JDK-8189263 Introduce CUSTOM_ROOT

2017-10-13 Thread David Holmes
Hi Magnus, I find this all very confusing - we have a number of CUSTOM_* variables now and I would expect they to be closely tied together. Also unclear if TOPDIR is really the top-dir or the top of the "open" repo? If really the top then aren't TOPDIR and CUSTOM_ROOT the same ?? Or are we al

RFR: JDK-8189263 Introduce CUSTOM_ROOT

2017-10-13 Thread Magnus Ihse Bursie
To support the use case where the OpenJDK repository is included as part of a custom project, this patch introduces the concept of a "custom root", which plays the role of $TOPDIR in some circumstances. It is the responsibility of any custom code to keep this value and propagate it where needed