Re: RFR: JDK-8192067 Add fixpath to test image

2017-11-29 Thread Magnus Ihse Bursie
On 2017-11-29 18:51, Erik Joelsson wrote: Looks good. (I would have done it with SetupCopyFiles, but this small rule declaration is OK too) Good point. I have to admit I didn't even think that far. If I ever need to touch the file again, I'll rewrite it using SetupCopyFiles. /Magnus /Erik

Re: RFR: JDK-8192067 Add fixpath to test image

2017-11-29 Thread Erik Joelsson
Looks good. (I would have done it with SetupCopyFiles, but this small rule declaration is OK too) /Erik On 2017-11-29 04:13, Magnus Ihse Bursie wrote: To be able to support the use case of running tests using the normal make files from prebuilt product and test images, we need to bundle the

Re: RFR: JDK-8192067 Add fixpath to test image

2017-11-29 Thread Tim Bell
Magnus: To be able to support the use case of running tests using the normal make files from prebuilt product and test images, we need to bundle the fixpath binary with the test image on Windows. Bug: https://bugs.openjdk.java.net/browse/JDK-8192067 WebRev: http://cr.openjdk.java.net/~ihse/JDK-

RFR: JDK-8192067 Add fixpath to test image

2017-11-29 Thread Magnus Ihse Bursie
To be able to support the use case of running tests using the normal make files from prebuilt product and test images, we need to bundle the fixpath binary with the test image on Windows. Bug: https://bugs.openjdk.java.net/browse/JDK-8192067 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8192067