Re: RFR: JDK-8196911: Windows build fails with not finding zlib.h

2018-02-07 Thread Thomas Stüfe
On Wed, Feb 7, 2018 at 3:20 PM, Alan Bateman wrote: > > > On 07/02/2018 14:13, Thomas Stüfe wrote: > >> Could this also explain what we see in some of our nightlies? The builds >> broke on some platforms for us (e.g. linux ppcle). It seems that >> "@LIBZ_CFLAGS@" does not get expanded correctly a

Re: RFR: JDK-8196911: Windows build fails with not finding zlib.h

2018-02-07 Thread Alan Bateman
On 07/02/2018 14:13, Thomas Stüfe wrote: Could this also explain what we see in some of our nightlies? The builds broke on some platforms for us (e.g. linux ppcle). It seems that "@LIBZ_CFLAGS@" does not get expanded correctly and finds its way into the makefile, confusing the compiler: ( /sap

Re: RFR: JDK-8196911: Windows build fails with not finding zlib.h

2018-02-07 Thread Thomas Stüfe
Could this also explain what we see in some of our nightlies? The builds broke on some platforms for us (e.g. linux ppcle). It seems that "@LIBZ_CFLAGS@" does not get expanded correctly and finds its way into the makefile, confusing the compiler: ( /sapmnt/appl_sw/gcc-4.8/bin/gcc ... -g1 -fPIC @LI

Re: RFR: JDK-8196911: Windows build fails with not finding zlib.h

2018-02-06 Thread Tim Bell
Erik: A small typo managed to sneak itself into my previous patch, causing the build to fail on Windows. Bug: https://bugs.openjdk.java.net/browse/JDK-8196911 [...snip...] - if test "x$USER_EXTERNAL_LIBZ" = "xfalse"; then + if test "x$USE_EXTERNAL_LIBZ" = "xfalse"; then Looks good. I mis

RFR: JDK-8196911: Windows build fails with not finding zlib.h

2018-02-06 Thread Erik Joelsson
A small typo managed to sneak itself into my previous patch, causing the build to fail on Windows. Bug: https://bugs.openjdk.java.net/browse/JDK-8196911 Patch inline: diff -r 0b1138ce244f make/autoconf/lib-bundled.m4 --- a/make/autoconf/lib-bundled.m4  Tue Feb 06 10:17:31 2018 -0800 +++ b/