Re: RFR: JDK-8198724 Refactor FLAGS handling in configure

2018-03-02 Thread Erik Joelsson
On 2018-03-02 01:54, Magnus Ihse Bursie wrote: I actually don't know of any cases where CFLAGS ordering is relevant. (LIBS is another issue) It's good to be aware of such issues, so please enlighten me. :-) If you have a flag that enables a feature and the corresponding disabling flag of the

Re: RFR: JDK-8198724 Refactor FLAGS handling in configure

2018-03-02 Thread Magnus Ihse Bursie
On 2018-03-02 00:46, Erik Joelsson wrote: Hello Magnus, Nice to finally see this posted! Overall very nice improvement. Thank you. I would advocate a simple bash replace to remove the dots, like this: MACOSX_VERSION_MIN_NODOTS=${MACOSX_VERSION_MIN//\./} Ok, I updated this. I see no need to

Re: RFR: JDK-8198724 Refactor FLAGS handling in configure

2018-03-01 Thread Erik Joelsson
Hello Magnus, Nice to finally see this posted! Overall very nice improvement. On 2018-02-26 15:40, Magnus Ihse Bursie wrote: The current way we're handling FLAGS (CFLAGS/CXXFLAGS, LDFLAGS, etc) is laden with technical debt. It's a sorry mess, hard to do anything constructive about. This is t

RFR: JDK-8198724 Refactor FLAGS handling in configure

2018-02-26 Thread Magnus Ihse Bursie
The current way we're handling FLAGS (CFLAGS/CXXFLAGS, LDFLAGS, etc) is laden with technical debt. It's a sorry mess, hard to do anything constructive about. This is the first step towards a better solution. The main goal is to have a set of more specific flags, more like how the SYSROOT flags