Re: RFR: JDK-8199428: install-file macro fails on filenames with space on Solaris

2018-03-10 Thread Magnus Ihse Bursie
Looks good to me. /Magnus > 10 mars 2018 kl. 00:42 skrev Erik Joelsson : > > A while back I implemented support for handling filenames with space in them > in the macros SetupCopyFiles and install-file. To verify this functionality I > added tests to our test-make suite. These tests currently

Re: RFR: JDK-8199428: install-file macro fails on filenames with space on Solaris

2018-03-09 Thread Tim Bell
Erik: This patch adds those EncodeSpace calls and makes all the test-make tests pass on Solaris. Bug: https://bugs.openjdk.java.net/browse/JDK-8199428 Webrev: http://cr.openjdk.java.net/~erikj/8199428/webrev.01/ Looks good. Tim

RFR: JDK-8199428: install-file macro fails on filenames with space on Solaris

2018-03-09 Thread Erik Joelsson
A while back I implemented support for handling filenames with space in them in the macros SetupCopyFiles and install-file. To verify this functionality I added tests to our test-make suite. These tests currently fail on Solaris. We currently don't use this functionality on Solaris, but keeping