Re: RFR: JDK-8199483 Clean up some non-standard LDFLAGS usage

2018-03-13 Thread Erik Joelsson
Right, explainable differences are fine of course. Thanks for the report! /Erik On 2018-03-13 03:27, Magnus Ihse Bursie wrote: On 2018-03-12 21:44, Erik Joelsson wrote: Looks good given that the comparison is clean (for the affected libs). That depends on what you mean as "clean". Of course

Re: RFR: JDK-8199483 Clean up some non-standard LDFLAGS usage

2018-03-13 Thread Magnus Ihse Bursie
On 2018-03-12 21:44, Erik Joelsson wrote: Looks good given that the comparison is clean (for the affected libs). That depends on what you mean as "clean". Of course there is a difference in deps for libsaproc.so on solaris, since we add a new library to link with. As a side effect, the disass

Re: RFR: JDK-8199483 Clean up some non-standard LDFLAGS usage

2018-03-12 Thread Erik Joelsson
Looks good given that the comparison is clean (for the affected libs). /Erik On 2018-03-12 13:03, Magnus Ihse Bursie wrote: We have a few libraries that, for one reason or another, use non-standard LDFLAGS. There is typically no good reason for this, just historical accidents. This patch fi

RFR: JDK-8199483 Clean up some non-standard LDFLAGS usage

2018-03-12 Thread Magnus Ihse Bursie
We have a few libraries that, for one reason or another, use non-standard LDFLAGS. There is typically no good reason for this, just historical accidents. This patch fixes several places to remove odd or unneeded LDFLAGS, and to make them conform better to the prevailing standard. This will fa