On 2018-06-14 12:49, Magnus Ihse Bursie wrote:
Would it have been to problematic to reverse the the logic, i.e.
having a "include translation" rather than an exclude? Feels more
brittle; if someone adds a translation the exclude list needs to be
updated. Also, a include mechanism could
Looks good to me.
Naoto
On 6/14/18 11:52 AM, Erik Joelsson wrote:
Hello,
Here is a new version of the patch:
http://cr.openjdk.java.net/~erikj/8204973/webrev.02/
Changes from last time:
* Made the regexp for finding locales more correct. It still does not
try to match 3 letter language
Would it have been to problematic to reverse the the logic, i.e. having
a "include translation" rather than an exclude? Feels more brittle; if
someone adds a translation the exclude list needs to be updated. Also, a
include mechanism could possibly be used, much simpler, by someone who
only
Hello,
Here is a new version of the patch:
http://cr.openjdk.java.net/~erikj/8204973/webrev.02/
Changes from last time:
* Made the regexp for finding locales more correct. It still does not
try to match 3 letter language strings because doing so triggers a large
amount of false positives in
Hi Erik,
The modifications to the logging test look good to me.
Caveat: I don't speak chinese nor japanese ;-)
cheers,
-- daniel
On 13/06/18 20:47, Erik Joelsson wrote:
Hello,
Oracle will reduce the number of languages that it maintains
translations of JDK resources for. The current
Hello,
Oracle will reduce the number of languages that it maintains
translations of JDK resources for. The current translations will remain
in the source for now, but we need a way to filter out a set of
translations at build time so that we only include the ones we support.
This patch adds
